Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-9] Remove filter box from chart types and create a filter panel #5925

Closed
3 tasks done
xtinec opened this issue Sep 18, 2018 · 2 comments
Closed
3 tasks done

[SIP-9] Remove filter box from chart types and create a filter panel #5925

xtinec opened this issue Sep 18, 2018 · 2 comments
Labels
sip Superset Improvement Proposal

Comments

@xtinec
Copy link
Contributor

xtinec commented Sep 18, 2018

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.27

Expected results

This is the first of a series of SIPs for the redesign of scoped filters.

Filter exists as its own concept instead of a chart type. This should be reflected both in the code architecture and the UI itself.

  • Filter Box is removed from chart types
  • New UI to create filters. Combine existing adhoc filters under the Query panel and the implicit filter under the Time panel as a uniformed filter creation UI (Mockups to come).
  • [Stretch goal] use Typescript for new filter code

Actual results

Filter box is a chart type.

Steps to reproduce

Add a filter box to any existing chart.

@betodealmeida betodealmeida added the sip Superset Improvement Proposal label Sep 19, 2018
@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@junlincc
Copy link
Member

Closing in favor of #10285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sip Superset Improvement Proposal
Projects
Status: Implemented / Done
Development

No branches or pull requests

4 participants