build: enable react-hooks linting #11006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a couple of criticle errors and left the warnings as is (mostly from react-hooks/exhaustive-deps). Let's fix the warnings in future PRs as sometimes unexhaustive deps are intentional.
ktmud
changed the title
ktmud
commented
Sep 22, 2020
| 'airbnb', | ||
| 'prettier', | ||
| 'prettier/react', | ||
| 'plugin:react-hooks/recommended', |
There was a problem hiding this comment.
eslint-airbnb has also airbnb/hooks to extend from, but it throws errors for inexhaustive deps.
nytai
approved these changes
Sep 22, 2020
6 tasks
rorymillersoft
referenced
this pull request
in nets-aric/incubator-superset
Oct 16, 2020
* master: (466 commits) chore: bump pandas to latest stable version (#11018) fix: dashboard edit button (again) (#11029) style(explore): use tertiary button against gray background (#11011) docs: add security vulnerability GH issue template (#11023) fix: [dashboard] should not show edit button when user has no edit permit (#11024) fix: timer component, fixes #10849, closes #11002 (#11004) fix: enable several pylint rules partially in db_engines_specs module (#11000) fix: pylint checks in connectors/sqla/models.py (#10974) fix: reenable pylint rule `unused-import` in charts and connectors modules (#11014) Enabled pylint rules in `db_engines` module: (#11016) fix: changes a pylint check in dashboard module (#10978) fix: menu shows a 0 when there are not settings (#11009) fix: query search low privileged user search access denied (#11017) chore: downgrade expected exception from error to info (#10994) fix: Add Item Overflow on Dataset Editor (#10983) Bring back import menu (#11007) feat(listview): feature flag config to set default viewing mode (#10986) build: add react-hooks linting (#11006) fix: unbreak ci (#11003) fix: enable pylint rules in db_engine_specs module (#10998) ... # Conflicts: # requirements.txt # superset/app.py # superset/models/schedules.py # superset/tasks/schedules.py # superset/translations/messages.pot
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Fixed a couple of criticle errors and left the warnings as is (mostly from react-hooks/exhaustive-deps). Let's fix the warnings in future PRs as sometimes unexhaustive deps are intentional.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
While working on #11004, I was suprised that we didn't have React hook checks turned on. So I added it.
Fixed a couple of criticle errors and left the warnings as is (mostly from react-hooks/exhaustive-deps).
Let's fix the warnings in future PRs as sometimes unexhaustive deps are intentional.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION