[add] Save filters to dashboard #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
2 similar comments
mistercrunch
reviewed
Aug 9, 2017
superset/models/core.py
Outdated
| filters = '' | ||
| if isinstance(default_filters, str): | ||
| filters = urllib.quote(default_filters) | ||
| elif isinstance(default_filters, unicode): |
There was a problem hiding this comment.
is this py3 compatible? can we add test coverage?
There was a problem hiding this comment.
Thanks, I will check these later.
mistercrunch
reviewed
Aug 9, 2017
| @@ -195,6 +199,13 @@ export function dashboardContainer(dashboard, datasources, userid) { | |||
| return f; | |||
| }, | |||
| addFilter(sliceId, col, vals, merge = true, refresh = true) { | |||
| // If slice doesn't exist, remove the related parameters in preselect_filters. | |||
There was a problem hiding this comment.
this function calls this.updateFilterParamsInUrl 3 times. Perhaps clearer logic would be an if statement that validates that there is a slice and column, put all the logic within that block, and call this.updateFilterParamsInUrl once at the very end
optimize the js code fix the compatibility issue
1 similar comment
|
@mistercrunch Thanks, code optimized. |
mistercrunch
approved these changes
Aug 11, 2017
|
This is great work, thanks for this feature! |
mistercrunch
added a commit
to mistercrunch/superset
that referenced
this pull request
Aug 18, 2017
apache#3183 disabled the ability of a filterbox to get filtered by another filterbox
mistercrunch
added a commit
that referenced
this pull request
Aug 18, 2017
* [dashboard] re-enabling cascading filters #3183 disabled the ability of a filterbox to get filtered by another filterbox * linting
3 tasks
3 tasks
2 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the filters of filter box to current dashboard.
