Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Don't cache if there's no cache key #4229

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

michellethomas
Copy link
Contributor

To follow up on this pr, we should also not add to cache if the cache_key is None.

@john-bodley @mistercrunch @graceguo-supercat

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@john-bodley
Copy link
Member

LGTM.

@mistercrunch mistercrunch merged commit 85d137b into apache:master Jan 18, 2018
@michellethomas michellethomas deleted the avoid_cache_no_cache_key branch January 18, 2018 16:41
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jan 18, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
michellethomas added a commit to michellethomas/panoramix that referenced this pull request May 24, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants