Refactoring deckgl #4293
Merged
Refactoring deckgl #4293
+256
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +12,6 @@ const layerGenerators = { | |||
| deck_screengrid, | |||
| deck_path, | |||
| deck_hex, | |||
| deck_scatter, | |||
There was a problem hiding this comment.
removing this here may break the deck_multi charts that combine deck_scatter
mistercrunch
requested changes
Jan 26, 2018
There was a problem hiding this comment.
I think this may break deck_multi, but otherwise it's the right general idea.
Looking at it now I'm thinking we may be able to keep the layers/ folder intact, and simply get rid of the the factory.jsx in favor of individual visualization function for each type.
|
Cool, will do. Thanks! |
betodealmeida
commented
Jan 29, 2018
| [VIZ_TYPES.deck_geojson]: deckglFactory, | ||
| [VIZ_TYPES.deck_arc]: deckglFactory, | ||
| [VIZ_TYPES.deck_polygon]: deckglFactory, | ||
| [VIZ_TYPES.deck_scatter]: require('./deckgl/layers/scatter.jsx').default, |
There was a problem hiding this comment.
@mistercrunch, is this the right approach? The module is now exporting two functions.
There was a problem hiding this comment.
We should probably move to ES6 imports at some point, not a req at the moment
mistercrunch
approved these changes
Jan 29, 2018
|
There's some JS lint otherwise LGTM |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Refactoring dekgl * Refactor layers * Standardize function name * Fix exports * Fix require * Fix lint
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Refactoring dekgl * Refactor layers * Standardize function name * Fix exports * Fix require * Fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch, publishing this early to get your thoughts (I'm planning to do it for all layers). Is this what you had in mind?