Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] resolve utf-8 encoding issue in db migration #4461

Merged
merged 6 commits into from
Feb 22, 2018

Conversation

timifasubaa
Copy link
Contributor

@timifasubaa timifasubaa commented Feb 21, 2018

Migrations cannot run because dashboard title contains utf8 characters.
We also rearranged the logging statement so as to have the ID of the failed dashboard show before it fails.

@john-bodley @graceguo-supercat @michellethomas

@michellethomas
Copy link
Contributor

lgtm

@mistercrunch mistercrunch merged commit 5830846 into apache:master Feb 22, 2018
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Feb 22, 2018
[hotfix] resolve utf-8 encoding issue in db migration (apache#4461)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* [hotfix] resolve utf-8 encoding issue in db migration

* make python string unicode

* Update e866bd2d4976_smaller_grid.py

* Update e866bd2d4976_smaller_grid.py

* rearrange the debug message

* Update e866bd2d4976_smaller_grid.py
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* [hotfix] resolve utf-8 encoding issue in db migration

* make python string unicode

* Update e866bd2d4976_smaller_grid.py

* Update e866bd2d4976_smaller_grid.py

* rearrange the debug message

* Update e866bd2d4976_smaller_grid.py
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants