Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-climate] Deprecating Code Climate from JavaScript tests #4582

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Mar 9, 2018

Given that we're now using codecov in Travis to process the various coverage reports, this PR deprecates outdated Code Climate logic.

@john-bodley john-bodley force-pushed the john-bodley-javascript-codecov branch 2 times, most recently from 072873f to dcb1a57 Compare March 9, 2018 06:38
@john-bodley john-bodley force-pushed the john-bodley-javascript-codecov branch from dcb1a57 to 3fbadd6 Compare March 9, 2018 06:40
@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #4582 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4582   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files         187      187           
  Lines       14809    14809           
  Branches     1085     1085           
=======================================
  Hits        10540    10540           
  Misses       4266     4266           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b512da8...3fbadd6. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Mar 9, 2018

🚢 RIP codeclimate

@john-bodley john-bodley merged commit c85eea3 into apache:master Mar 9, 2018
@john-bodley john-bodley deleted the john-bodley-javascript-codecov branch March 9, 2018 17:02
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
…t-codecov

[code-climate] Deprecating Code Climate from JavaScript tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants