Move run_extra_queries outsize of BaseViz init #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
fix_run_extra
branch
from
90fa3f0 to
b906fec
Compare
Codecov Report
@@ Coverage Diff @@
## master #4627 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 189 189
Lines 14848 14848
Branches 1087 1087
=======================================
Hits 10568 10568
Misses 4277 4277
Partials 3 3
Continue to review full report at Codecov.
|
|
This lgtm, I tested on a few dashboards that had slices with a time compare set. Thanks for the quick fix |
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Move run_extra_queries outsize of BaseViz init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_extra_querieson viz init makes it such that it will run when crafting the dashboard bootstrap payload page which is badNOTE: I haven't had time to thoroughly test this. I'll update here as I do.