Add 24 hours refresh for dashboard

[aok1425]

For dashboards, add additional autorefresh time interval options of 30m, 1h, 6h, 12h, and 24h.

Fixes #5058.
@mistercrunch @michellethomas @niksem

[mistercrunch]

Mind adding incremental values while at it? Maybe 15 minutes, 30 minutes, 1 hour, 6 hours, ...

[aok1425]

Oh good idea! done

[codecov-io]

Codecov Report

Merging #5068 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5068   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files          44       44           
  Lines        8712     8712           
=======================================
  Hits         6755     6755           
  Misses       1957     1957

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d322e48...bfae21e. Read the comment docs.

[yamyamyuo]

@aok1425 just curious, why not just let the user to set the interval instead of providing the options? Like some data may be required to refresh weekly or monthly.

[aok1425]

@yamyamyuo I wanted my Superset dash to update every 24h, and I don't know enough JS to let the user set the interval :)

Maybe you want to build the feature to let the user set the interval? I'm imagining something like a horizontal slider might be a good design.

[salonijain024]

I tried to add new refresh option but it is not reflected on dashboard.
Can you help in reflecting the changes

[aok1425]

@salonijain024 I don't understand what you're saying. Can you link to your PR?

[salonijain024]

Hi, I mean I am adding new refresh time in the code as mentioned on the ticket and restarting superset server. But the changes are not reflected. I need assistance to reflect my changes Regards, Saloni

…

On Thu, Aug 30, 2018, 12:52 PM Alexander Ko ***@***.***> wrote: @salonijain024 <https://github.com/salonijain024> I don't understand what you're saying. Can you link to your PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQmV_4nVenWHII4kNKjgJ-6ke6d1P695ks5uV5LGgaJpZM4ULihg> .

[mistercrunch]

@salonijain024 if you change the JS code you need to rebuild it. Check out our CONTRIBUTING.md file.

[salonijain024]

Hi, Thank you so much for your support. It worked and I am able to add custom refresh time. Regards, Saloni

…

On Thu, Aug 30, 2018, 8:49 PM Maxime Beauchemin ***@***.***> wrote: @salonijain024 <https://github.com/salonijain024> if you change the JS code you need to rebuild it. Check out our CONTRIBUTING.md file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQmV_2e4JttNM35mA2KhQXFCSHFfp391ks5uWAKNgaJpZM4ULihg> .

[salonijain024]

Hi, I have another version of superset on production and i am trying to implement the same on 0.24.0 version of superset. here i am facing below issue. Can you please help me to resolve the same: Thanks and Regards, Saloni Jain On Thu, Aug 30, 2018 at 10:27 PM SALONI JAIN <[email protected]> wrote:

Hi, Thank you so much for your support. It worked and I am able to add custom refresh time. Regards, Saloni On Thu, Aug 30, 2018, 8:49 PM Maxime Beauchemin ***@***.***> wrote: > @salonijain024 <https://github.com/salonijain024> if you change the JS > code you need to rebuild it. Check out our CONTRIBUTING.md file. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#5068 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQmV_2e4JttNM35mA2KhQXFCSHFfp391ks5uWAKNgaJpZM4ULihg> > . >

0 info it worked if it ends with ok 1 verbose cli [ '/root/.nvm/versions/node/v8.9.4/bin/node', 1 verbose cli '/root/.nvm/versions/node/v8.9.4/bin/npm', 1 verbose cli 'run', 1 verbose cli 'lint' ] 2 info using [email protected] 3 info using [email protected] 4 verbose run-script [ 'prelint', 'lint', 'postlint' ] 5 info lifecycle [email protected]~prelint: [email protected] 6 info lifecycle [email protected]~lint: [email protected] 7 verbose lifecycle [email protected]~lint: unsafe-perm in lifecycle true 8 verbose lifecycle [email protected]~lint: PATH: /root/.nvm/versions/node/v8.9.4/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/srv/superset/venv/lib/python2.7/site-packages/superset/static/assets/node_modules/.bin:/root/.nvm/versions/node/v8.9.4/bin:/srv/superset/venv/bin:/root/.gem/ruby/2.4.0/bin:/opt/ruby/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin 9 verbose lifecycle [email protected]~lint: CWD: /srv/superset/venv/lib/python2.7/site-packages/superset/static/assets 10 silly lifecycle [email protected]~lint: Args: [ '-c', 'eslint --ignore-path=.eslintignore --ext .js,.jsx .' ] 11 silly lifecycle [email protected]~lint: Returned: code: 1 signal: null 12 info lifecycle [email protected]~lint: Failed to exec lint script 13 verbose stack Error: [email protected] lint: `eslint --ignore-path=.eslintignore --ext .js,.jsx .` 13 verbose stack Exit status 1 13 verbose stack at EventEmitter.<anonymous> (/root/.nvm/versions/node/v8.9.4/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:285:16) 13 verbose stack at emitTwo (events.js:126:13) 13 verbose stack at EventEmitter.emit (events.js:214:7) 13 verbose stack at ChildProcess.<anonymous> (/root/.nvm/versions/node/v8.9.4/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14) 13 verbose stack at emitTwo (events.js:126:13) 13 verbose stack at ChildProcess.emit (events.js:214:7) 13 verbose stack at maybeClose (internal/child_process.js:925:16) 13 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5) 14 verbose pkgid [email protected] 15 verbose cwd /srv/superset/venv/lib/python2.7/site-packages/superset/static/assets 16 verbose Linux 3.10.0-693.21.1.el7.x86_64 17 verbose argv "/root/.nvm/versions/node/v8.9.4/bin/node" "/root/.nvm/versions/node/v8.9.4/bin/npm" "run" "lint" 18 verbose node v8.9.4 19 verbose npm v5.6.0 20 error code ELIFECYCLE 21 error errno 1 22 error [email protected] lint: `eslint --ignore-path=.eslintignore --ext .js,.jsx .` 22 error Exit status 1 23 error Failed at the [email protected] lint script. 23 error This is probably not a problem with npm. There is likely additional logging output above. 24 verbose exit [ 1, true ]

[mistercrunch]

0.24 is old, why not upgrading to a newer version?

[salonijain024]

Hi, I understand but that my version is old but currently we have a production release and cannot afford to have a version change. We were looking for a hotfix on the same version we are using. I would request you to kindly some assistance to fix it. Regards, Saloni Jain

…

On Fri, Aug 31, 2018 at 10:11 PM Maxime Beauchemin ***@***.***> wrote: 0.24 is old, why not upgrading to a newer version? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQmV_9KnKDrebQCCifEiWmEA1Sb7Qausks5uWWcqgaJpZM4ULihg> .

[yamyamyuo]

I have copy some of the code from Dockerfile, ignore the number in the front of each line
Hope this could do some help, this works in my production release.

Steps of code

• install nodejs, yarn, npm
• modify your frontend code
• cd superset/assets && yarn && npm run build

`# Install nodejs for custom build
48 # https://nodejs.org/en/download/package-manager/
49 RUN curl -sL https://deb.nodesource.com/setup_9.x | bash -
50 RUN apt-get update && apt-get install -y nodejs
51 RUN npm install -g yarn

53 RUN ls ${SUPERSET_ASSETS_DIR}
54 COPY ./lls_superset_build/package.json ${SUPERSET_ASSETS_DIR}/package.json # i have modify something here

RUN cd ${SUPERSET_ASSETS_DIR} && yarn
61 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack

compile the frontend

49 # https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build
50 RUN cd ${SUPERSET_ASSETS_DIR} && yarn
51 # RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack

56 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list
58 RUN cd ${SUPERSET_ASSETS_DIR} && npm run build
`

[salonijain024]

Thanks for the help. I will do the same and update you in case of any issue. Regards, Saloni

…

On Wed, Sep 5, 2018, 1:07 PM yamyamyuo ***@***.***> wrote: `# Install nodejs for custom build 48 # https://nodejs.org/en/download/package-manager/ 49 RUN curl -sL https://deb.nodesource.com/setup_9.x | bash - 50 RUN apt-get update && apt-get install -y nodejs 51 RUN npm install -g yarn 53 RUN ls ${SUPERSET_ASSETS_DIR} 54 COPY ./lls_superset_build/package.json ${SUPERSET_ASSETS_DIR}/package.json # i have modify something here RUN cd ${SUPERSET_ASSETS_DIR} && yarn 61 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack compile the frontend 49 # https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build 50 RUN cd ${SUPERSET_ASSETS_DIR} && yarn 51 # RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack 56 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list 58 RUN cd ${SUPERSET_ASSETS_DIR} && npm run build ` — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5068 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQmV_6-Pma7yflg4rJaMLKRjnFyi_V-Mks5uX38mgaJpZM4ULihg> .

[salonijain024]

Hi, Can you help me with upgrading superset without impacting existing data on old version of superset. Our production superset version is very old and we need to upgrade, but do not want to impact the existing dashboards and rework on the same. Kindly assist. Regards, Saloni Jain

…

On Wed, Sep 5, 2018, 3:04 PM SALONI JAIN ***@***.***> wrote: Thanks for the help. I will do the same and update you in case of any issue. Regards, Saloni On Wed, Sep 5, 2018, 1:07 PM yamyamyuo ***@***.***> wrote: > `# Install nodejs for custom build > 48 # https://nodejs.org/en/download/package-manager/ > 49 RUN curl -sL https://deb.nodesource.com/setup_9.x | bash - > 50 RUN apt-get update && apt-get install -y nodejs > 51 RUN npm install -g yarn > > 53 RUN ls ${SUPERSET_ASSETS_DIR} > 54 COPY ./lls_superset_build/package.json > ${SUPERSET_ASSETS_DIR}/package.json # i have modify something here > > RUN cd ${SUPERSET_ASSETS_DIR} && yarn > 61 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack > compile the frontend > > 49 # > https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build > 50 RUN cd ${SUPERSET_ASSETS_DIR} && yarn > 51 # RUN cd ${SUPERSET_ASSETS_DIR} && yarn list webpack > > 56 RUN cd ${SUPERSET_ASSETS_DIR} && yarn list > 58 RUN cd ${SUPERSET_ASSETS_DIR} && npm run build > ` > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#5068 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQmV_6-Pma7yflg4rJaMLKRjnFyi_V-Mks5uX38mgaJpZM4ULihg> > . >

[mistercrunch]

@salonijain024 this PR is not the right outlet to discuss this, please open an issue with the specifics