[Explore][Adhoc Metrics/ Filters] disabled message for custom sql tab in druid #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you have a formatting linting issue, but otherwise this lgtm! |
Fixing indentation.
Fixing indent.
Fixing indentation.
Fixing indentation.
Codecov Report
@@ Coverage Diff @@
## master #5162 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 44 44
Lines 8741 8741
=======================================
Hits 6772 6772
Misses 1969 1969Continue to review full report at Codecov.
|
|
👍 |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Jun 7, 2018
… in druid (apache#5162) * added disabled message for custom sql tab on druid datasources * Update AdhocFilterEditPopover.jsx Fixing indentation. * Update AdhocMetricEditPopover.jsx Fixing indent. * Update AdhocFilterEditPopover.jsx Fixing indentation. * Update AdhocMetricEditPopover.jsx Fixing indentation. (cherry picked from commit b53b240)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
… in druid (apache#5162) * added disabled message for custom sql tab on druid datasources * Update AdhocFilterEditPopover.jsx Fixing indentation. * Update AdhocMetricEditPopover.jsx Fixing indent. * Update AdhocFilterEditPopover.jsx Fixing indentation. * Update AdhocMetricEditPopover.jsx Fixing indentation.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Custom SQL tab only makes sense for SQLA datasources since its quite difficult to write custom druid json queries. To avoid confusion of why the tab is present on sqla datasources but not druid, I added the tab back in for druid datasources with a placeholder message explaining why its not available.
before:
after:
test plan:
to:
@michellethomas @john-bodley @graceguo-supercat @mistercrunch