Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IS NOT NULL and IS NULL as filter options #5375

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Add IS NOT NULL and IS NULL as filter options #5375

merged 3 commits into from
Jul 16, 2018
+12 −1

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 11, 2018 •
edited
Loading

  • Add both IS NOT NULL and IS NULL as independent options
  • Disable option bar to pick comparer if 1 of the 2 options is selected.

@codecov-io
Copy link

codecov-io commented Jul 11, 2018 •
edited
Loading

Codecov Report

Merging #5375 into master will decrease coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5375      +/-   ##
=========================================
- Coverage   61.31%   61.3%   -0.01%     
=========================================
  Files         369     369              
  Lines       23497   23502       +5     
  Branches     2715    2719       +4     
=========================================
+ Hits        14407   14408       +1     
- Misses       9078    9082       +4     
  Partials       12      12
Impacted Files Coverage Δ
superset/assets/src/explore/constants.js 100% <ø> (ø) ⬆️
superset/assets/src/explore/AdhocFilter.js 86.15% <20%> (-5.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b15592...7f8342d. Read the comment docs.

@mistercrunch
Copy link
Member

Thanks for picking this up!

@hughhhh hughhhh changed the title [Wip] Add IS NOT NULL and IS NULL as filter options Add IS NOT NULL and IS NULL as filter options Jul 16, 2018
mistercrunch
mistercrunch reviewed Jul 16, 2018
View reviewed changes
superset/assets/src/explore/components/AdhocMetricEditPopover.jsx Outdated
@@ -200,7 +200,7 @@ export default class AdhocMetricEditPopover extends React.Component {

const stateIsValid = adhocMetric.isValid();
const hasUnsavedChanges = !adhocMetric.equals(propsAdhocMetric);

// I think we can delete this right???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@mistercrunch
Copy link
Member

Build has been fixed, please rebase

hughhhh added 3 commits July 16, 2018 12:10
@hughhhh
wip
8d36677
@hughhhh
disable value selector on IS NOT NULL or NOT NULL
2e49135
@hughhhh
remove this

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cbc0d2d
@mistercrunch
Copy link
Member

LGTM

@hughhhh hughhhh merged commit e79bb92 into apache:master Jul 16, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@hughhhh @timifasubaa
Add IS NOT NULL and IS NULL as filter options (apache#5375)
1651887 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (apache#5375)
feda7e3 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this

(cherry picked from commit e79bb92)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (apache#5375)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
884d7cc 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this

(cherry picked from commit e79bb92)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (apache#5375)
1c360c6 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this

(cherry picked from commit e79bb92)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (apache#5375)
fc6361c 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this

(cherry picked from commit e79bb92)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (apache#5375)
8a4154b 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this

(cherry picked from commit e79bb92)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (apache#5375)
78df7e0 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this

(cherry picked from commit e79bb92)
mistercrunch pushed a commit that referenced this pull request Aug 12, 2018
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (#5375)
ac81848 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@hughhhh
Add IS NOT NULL and IS NULL as filter options (apache#5375)
d9e014d 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@hughhhh @mistercrunch
Add IS NOT NULL and IS NULL as filter options (apache#5375)
80513f7 
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughhhh @codecov-io @mistercrunch