-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IS NOT NULL
and IS NULL
as filter options
#5375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5375 +/- ##
=========================================
- Coverage 61.31% 61.3% -0.01%
=========================================
Files 369 369
Lines 23497 23502 +5
Branches 2715 2719 +4
=========================================
+ Hits 14407 14408 +1
- Misses 9078 9082 +4
Partials 12 12
Continue to review full report at Codecov.
|
Thanks for picking this up! |
IS NOT NULL
and IS NULL
as filter optionsIS NOT NULL
and IS NULL
as filter options
@@ -200,7 +200,7 @@ export default class AdhocMetricEditPopover extends React.Component { | |||
|
|||
const stateIsValid = adhocMetric.isValid(); | |||
const hasUnsavedChanges = !adhocMetric.equals(propsAdhocMetric); | |||
|
|||
// I think we can delete this right??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Build has been fixed, please rebase |
LGTM |
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this (cherry picked from commit e79bb92)
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this (cherry picked from commit e79bb92)
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this (cherry picked from commit e79bb92)
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this (cherry picked from commit e79bb92)
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this (cherry picked from commit e79bb92)
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this (cherry picked from commit e79bb92)
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this
* wip * disable value selector on IS NOT NULL or NOT NULL * remove this
IS NOT NULL
andIS NULL
as independent options