Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time filter fixes #5448

Merged
merged 3 commits into from
Jul 20, 2018
Merged

Time filter fixes #5448

merged 3 commits into from
Jul 20, 2018

Conversation

betodealmeida
Copy link
Member

A PR with small fixes for the new time filter:

  • World's Bank Data now initializes correctly.
  • Added a new option "No filter" (see screenshot).
  • Added "Last quarter" to list of default time ranges.
  • Updated backend to handle "Last day" and "Last quarter".

screen shot 2018-07-20 at 1 21 05 pm

@codecov-io
Copy link

Codecov Report

Merging #5448 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5448      +/-   ##
=========================================
+ Coverage    59.1%   59.1%   +<.01%     
=========================================
  Files         372     372              
  Lines       23742   23744       +2     
  Branches     2758    2758              
=========================================
+ Hits        14033   14035       +2     
  Misses       9694    9694              
  Partials       15      15
Impacted Files Coverage Δ
.../explore/components/controls/DateFilterControl.jsx 60.55% <ø> (ø) ⬆️
superset/data/__init__.py 100% <ø> (ø) ⬆️
superset/utils.py 89.01% <50%> (-0.15%) ⬇️
superset/viz.py 77.41% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41447e8...023174e. Read the comment docs.

@mistercrunch mistercrunch merged commit 83e1e2c into apache:master Jul 20, 2018
@mistercrunch mistercrunch deleted the time_filter_fixes branch July 20, 2018 22:15
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
* Fixes for the new time filter

* Fix dashboard

* Trigger tests
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Fixes for the new time filter

* Fix dashboard

* Trigger tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants