Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify title when importing a table #5454

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 20, 2018

The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.
screen shot 2018-07-20 at 4 32 22 pm

The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.
@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #5454 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5454   +/-   ##
=======================================
  Coverage   59.11%   59.11%           
=======================================
  Files         372      372           
  Lines       23756    23756           
  Branches     2758     2758           
=======================================
  Hits        14044    14044           
  Misses       9697     9697           
  Partials       15       15
Impacted Files Coverage Δ
superset/connectors/sqla/views.py 70.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c545fdf...3a53d78. Read the comment docs.

@mistercrunch mistercrunch merged commit 6e7b587 into apache:master Jul 21, 2018
@mistercrunch mistercrunch deleted the clarify_msg branch July 21, 2018 17:39
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.

(cherry picked from commit 6e7b587)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.

(cherry picked from commit 6e7b587)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.

(cherry picked from commit 6e7b587)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.

(cherry picked from commit 6e7b587)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.

(cherry picked from commit 6e7b587)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.

(cherry picked from commit 6e7b587)
mistercrunch added a commit that referenced this pull request Aug 12, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants