-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken dedup and remove redundant db_spec logic #5467
Conversation
@mistercrunch The lowercasing hack was introduced to deal with SQLA engines that returned different cases for column names in the cursor.description (db api 1) which was used by e.g. SQL Lab and ResultProxy.keys() (db api 2), which was used for retrieving data. #5178 replaced all v2 api calls with v1 calls, ensuring that the column names are always of the same case. |
Codecov Report
@@ Coverage Diff @@
## master #5467 +/- ##
==========================================
- Coverage 59.12% 59.11% -0.01%
==========================================
Files 372 372
Lines 23762 23751 -11
Branches 2758 2758
==========================================
- Hits 14049 14041 -8
+ Misses 9698 9695 -3
Partials 15 15
Continue to review full report at Codecov.
|
LGTM |
* Fix broken dedup and remove redundant db_spec logic * Add test case
* Fix broken dedup and remove redundant db_spec logic * Add test case
Fixes regression introduced by PR #4724 that broke column name deduplication. Also remove column name lowercasing logic from db_engine_spec that was made redundant by PR #5178.