No exception on no data #5597
Merged
No exception on no data #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5597 +/- ##
=========================================
+ Coverage 63.6% 63.6% +<.01%
=========================================
Files 359 359
Lines 22786 22789 +3
Branches 2532 2532
=========================================
+ Hits 14492 14494 +2
- Misses 8279 8280 +1
Partials 15 15
Continue to review full report at Codecov.
|
|
What will transpire in the UI for a No Data? Right now GeoVis actually uses that exception (400 status code) for indicating there isn't data available. https://github.com/apache/incubator-superset/blob/master/superset/exceptions.py#L25 |
|
@hughhhh, the UI will now show the yellow bar with the text "No Data". The exception is raised later in |
|
🚢 |
|
LGTM |
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 21, 2018
* No exception on no data * Remove unreachable exception (cherry picked from commit 763eeca)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* No exception on no data * Remove unreachable exception (cherry picked from commit 763eeca)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 22, 2018
* No exception on no data * Remove unreachable exception (cherry picked from commit 763eeca)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* No exception on no data * Remove unreachable exception
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to replicate a bug I found out to the backend is raising exceptions when no data is returned, both in Druid (explicitly) and in SQLAlchemy (iterating over a
cursor.descriptionthat isNone).I think the SQLAlchemy bug happens only in conjunction with the
druidbackend, and I recently fixed it (druid-io/pydruid#133). But it's better to be on the safe side here.