Prevent deleting databases that have attached tables #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to logic preventing deleting tables that have charts attached.
superset/views/core.py
Outdated
| raise SupersetException(Markup( | ||
| 'Cannot delete a database that has tables attached. ' | ||
| "Here's the list of associated tables: " + | ||
| ''.join(['{}'.format(o) for o in obj.tables]))) |
There was a problem hiding this comment.
You want to join them with a comma here, no? Also, you don't need format nor the list comprehension:
', '.join(str(o) for o in obj.tables)))There was a problem hiding this comment.
Somehow I missed the coma... About str I've been steering away from it since in py2 it won't do unicode properly. .format() always work and does unicode if using the future unicode literals imports.
I'm surprised to see the comprehension working without the brackets, I'm guessing then it's a generator.
There was a problem hiding this comment.
Ah, true... I keep forgetting about Python 2.
And yeah, removing the brackets create a generator which is immediately consumed by the join method.
Codecov Report
@@ Coverage Diff @@
## master #5749 +/- ##
==========================================
- Coverage 63.43% 63.43% -0.01%
==========================================
Files 362 362
Lines 22983 22986 +3
Branches 2557 2557
==========================================
+ Hits 14580 14581 +1
- Misses 8388 8390 +2
Partials 15 15
Continue to review full report at Codecov.
|
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments (cherry picked from commit 6cc52c6)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Prevent deleting databases that have attached tables Similar to logic preventing deleting tables that have charts attached. * Addressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to logic preventing deleting tables that have charts attached.