[SIP-5] Refactor rose #5763
Merged
[SIP-5] Refactor rose #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5763 +/- ##
==========================================
- Coverage 63.8% 63.78% -0.02%
==========================================
Files 364 364
Lines 23066 23073 +7
Branches 2568 2568
==========================================
Hits 14717 14717
- Misses 8334 8341 +7
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Aug 29, 2018
| import './rose.css'; | ||
|
|
||
| const propTypes = { | ||
| // Data is an object hashed by numeric value, perhaps timestamp |
There was a problem hiding this comment.
Does it work do specify this like this?
data: PropTypes.objectOf(
PropTypes.arrayOf(PropTypes.shape({ ... }),
),There was a problem hiding this comment.
Good call. Will update
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 5, 2018
* refactor rose * update proptypes (cherry picked from commit 86f99b0)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* refactor rose * update proptypes
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* refactor rose * update proptypes
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sliceandformDatafrom chart.Tested locally
@williaster @conglei