[SIP-5] Refactor Time Series Table #5775
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5775 +/- ##
==========================================
- Coverage 63.73% 63.63% -0.11%
==========================================
Files 374 375 +1
Lines 23325 23363 +38
Branches 2607 2618 +11
==========================================
Hits 14867 14867
- Misses 8445 8483 +38
Partials 13 13
Continue to review full report at Codecov.
|
| class TimeTable extends React.PureComponent { | ||
| renderLeftCell(row) { | ||
| const { rowType, url } = this.props; | ||
| // const context = { ...fd, metric }; |
There was a problem hiding this comment.
Does the url templating need anything other than the metric?
The commented was the original code and I was not sure if the url template wants something else from formData.
There was a problem hiding this comment.
Ohh I see. I think Michelle knows more about templating or @mistercrunch
There was a problem hiding this comment.
Hi @michellethomas , we would love your thoughts about the url template in time series table.
There was a problem hiding this comment.
I think it's was created to be used with metric, I can't think of anything else in formData that would be useful in the url. If you want to be sure, we can query charts that use this feature.
kristw
force-pushed
the
kristw-time-table
branch
from
53cbd4b to
9190f90
Compare
|
@kristw is this one ready to merge when the build passes? |
|
Yes, it is ready. |
* Break TimeTable into smaller pieces * extract function to compute color * Handle height and scrollbar * sort out isGroupBy * Set default values * Specify proptypes for data * rename fields and update proptypes * Add default props * remove commented line * swap import
|
Then this one maybe the reason to break the Time Series Table features from version 0.28.0 :( |
mistercrunch
added
🏷️ bot
sliceandformDataVerify same slice on production and produce the same result.