[SIP-5] Refactor filterbox #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5789 +/- ##
==========================================
- Coverage 63.73% 63.71% -0.02%
==========================================
Files 366 366
Lines 23132 23139 +7
Branches 2598 2597 -1
==========================================
Hits 14744 14744
- Misses 8373 8380 +7
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Sep 5, 2018
| @@ -1,5 +1,3 @@ | |||
| // JS | |||
| import d3 from 'd3'; | |||
| label={t('Time range')} | ||
| description={t('Select start and end date')} | ||
| onChange={this.changeFilter.bind(this, timeRange)} | ||
| value={this.state.selectedValues[timeRange]} | ||
| onChange={this.changeFilter.bind(this, TIME_RANGE)} |
There was a problem hiding this comment.
nit -- could we bind this in the constructor?
| <OnPasteSelect | ||
| placeholder={t('Select [%s]', filter)} | ||
| key={filter} | ||
| placeholder={t('Select [%s]', key)} |
There was a problem hiding this comment.
should this one use label instead of key?
| @@ -195,21 +218,26 @@ class FilterBox extends React.Component { | |||
| }; | |||
| return { value: opt.id, label: opt.id, style }; | |||
| })} | |||
| onChange={this.changeFilter.bind(this, filter)} | |||
| onChange={this.changeFilter.bind(this, key)} | |||
There was a problem hiding this comment.
nit -- could we bind this in the constructor?
kristw
force-pushed
the
kristw-filterbox
branch
from
6fe6528 to
c5d5066
Compare
kristw
force-pushed
the
kristw-filterbox
branch
from
c5d5066 to
a6bd8c0
Compare
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* reorganize variables * bring back datasource * refactor filter box * rename constants to all caps and update prop types * bind this.changeFilter * update event handler
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* reorganize variables * bring back datasource * refactor filter box * rename constants to all caps and update prop types * bind this.changeFilter * update event handler
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d3.PropTypes