Adding line and big number total integration tests #5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
reviewed
Sep 10, 2018
| @@ -4,7 +4,6 @@ | |||
|
|
|||
There was a problem hiding this comment.
Perhaps break this file into multiple files, one per chart, to avoid this becoming viz.py
| }); | ||
| }); | ||
|
|
||
| Cypress.Commands.add('verifySliceSuccess', ({ waitAlias, querySubstring, getSvg = true }) => { |
There was a problem hiding this comment.
Perhaps change getSvg:boolean to chartSelector:String will make this more flexible and support non-svg charts as well.
| Cypress.Commands.add('verifySliceSuccess', ({ waitAlias, querySubstring, getSvg = true }) => { | ||
| cy.wait([waitAlias]).then((data) => { | ||
| expect(data.status).to.eq(200); | ||
| expect(data.response.body).to.have.property('error', null); |
There was a problem hiding this comment.
Does this work if error is undefined?
| } | ||
| cy.get('.slice_container').within(() => { | ||
| if (getSvg) { | ||
| cy.get('svg').should('have.attr', 'height').then((height) => { |
There was a problem hiding this comment.
// change 'svg' to the chartSelector parameter to support 'div', 'table', etc.
if(chartSelector) {
cy.get(chartSelector).then(chart => {
// This should work for getting DOM element dimension in general
// to support div that has no 'width', 'height' attributes.
expect(chart.clientWidth).greaterThan(0);
expect(chart.clientHeight).greaterThan(0);
});
}
| }); | ||
|
|
||
| Cypress.Commands.add('verifySliceSuccess', ({ waitAlias, querySubstring, getSvg = true }) => { | ||
| cy.wait([waitAlias]).then((data) => { |
There was a problem hiding this comment.
Can cy.wait() take the alias string directly without wrapping it into an array?
cy.wait(waitAlias)
Codecov Report
@@ Coverage Diff @@
## master #5846 +/- ##
==========================================
+ Coverage 63.73% 63.75% +0.01%
==========================================
Files 368 374 +6
Lines 23221 23320 +99
Branches 2600 2608 +8
==========================================
+ Hits 14801 14867 +66
- Misses 8405 8440 +35
+ Partials 15 13 -2
Continue to review full report at Codecov.
|
kristw
approved these changes
Sep 11, 2018
|
Thanks for all the good comments Krist! |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Adding line and big number total integration tests * Breakout visualization tests into multiple files
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Adding line and big number total integration tests * Breakout visualization tests into multiple files
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created tests for different configurations of line chart and big number total.
Adding a check for svg height and width > 0 where appropriate. Also adding a check if the query contains a substring (to make sure the metric exists in the query for example).
@graceguo-supercat @kristw