Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] 'No numeric types to aggregate' in NVD3 chart #5853

Merged
merged 1 commit into from
Sep 11, 2018
Merged

[bugfix] 'No numeric types to aggregate' in NVD3 chart #5853

merged 1 commit into from
Sep 11, 2018

Conversation

mistercrunch
Copy link
Member

Another bug related to old vs new metric format. This one here prevented the enforce_numerical_metrics = True-related logic to execute

@codecov-io
Copy link

Codecov Report

Merging #5853 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5853      +/-   ##
==========================================
+ Coverage   63.75%   63.75%   +<.01%     
==========================================
  Files         374      374              
  Lines       23320    23321       +1     
  Branches     2608     2608              
==========================================
+ Hits        14867    14868       +1     
  Misses       8440     8440              
  Partials       13       13
Impacted Files Coverage Δ
superset/viz.py 81.44% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73db918...3aa8b0e. Read the comment docs.

@betodealmeida betodealmeida merged commit 73cfccc into apache:master Sep 11, 2018
@betodealmeida
Copy link
Member

LGTM

kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 18, 2018
@mistercrunch @kristw
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
9019068 
(cherry picked from commit 73cfccc)
@kristw kristw mentioned this pull request Sep 18, 2018
Merged
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
262dd93 
(cherry picked from commit 73cfccc)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
ede6741 
(cherry picked from commit 73cfccc)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
1f18688 
(cherry picked from commit 73cfccc)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
1de80cd 
(cherry picked from commit 73cfccc)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@mistercrunch
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
a2c0120 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
4e7f0a1 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
a2c0675
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
28ad7aa 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
0234437 
(cherry picked from commit 73cfccc)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
cb4a44e 
(cherry picked from commit 73cfccc)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
717dbb9 
(cherry picked from commit 73cfccc)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
29cf6eb 
(cherry picked from commit 73cfccc)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@mistercrunch @youngyjd
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
4f1954c 
(cherry picked from commit 73cfccc)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
@mistercrunch
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
1029ba1 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
dddf359 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
ce79da4 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
fbbbfc1 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
0c54786 
(cherry picked from commit 73cfccc)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
7f6e862 
(cherry picked from commit 73cfccc)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
6999d56 
(cherry picked from commit 73cfccc)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@mistercrunch @youngyjd
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
f493640 
(cherry picked from commit 73cfccc)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch @betodealmeida
[bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853)
562bc21
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @codecov-io @betodealmeida