-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] mapbox pan on filter #5858
Conversation
- Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default
…ry for computing the viewport now that it is driven by the bounds from the backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -9,9 +9,6 @@ export const LUMINANCE_RED_WEIGHT = 0.2126; | |||
export const LUMINANCE_GREEN_WEIGHT = 0.7152; | |||
export const LUMINANCE_BLUE_WEIGHT = 0.0722; | |||
export const MILES_PER_KM = 1.60934; | |||
export const DEFAULT_LONGITUDE = -122.405293; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@@ -6,12 +6,6 @@ import Immutable from 'immutable'; | |||
import supercluster from 'supercluster'; | |||
import ViewportMercator from 'viewport-mercator-project'; | |||
import ScatterPlotGlowOverlay from './ScatterPlotGlowOverlay'; | |||
|
|||
import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits, otherwise LGTM.
As discussed we should eventually deprecate this viz and resolve the github fork ref in package.json
. The deck_
are superior, and have things like a ViewportControl
, support the "time player", ...
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups) (cherry picked from commit 6df720d)
* Pan mapbox map on query - Modify the backend to send back the bounds of the points to cluster - Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom - A minor clean up of unused props and also making the visual properties panel open by default * Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend. * a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups)
@mistercrunch @betodealmeida @youngyjd