Deprecate support for Python < 3.6 #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
py3
branch
2 times, most recently
from
92b20ea to
455d204
Compare
Codecov Report
@@ Coverage Diff @@
## master #5985 +/- ##
==========================================
+ Coverage 77.79% 77.84% +0.05%
==========================================
Files 46 46
Lines 9398 9398
==========================================
+ Hits 7311 7316 +5
+ Misses 2087 2082 -5
Continue to review full report at Codecov.
|
|
+1 for enjoy ourselves |
|
@mistercrunch this line should be removed: https://github.com/apache/incubator-superset/blob/master/tox.ini#L41 |
|
|
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Deprecate support for Python < 3.6 This is a first step, beyond this we can: * remove all from future imports * remove 'six' lib as a dependency * start using f-strings * enjoy ourselves * fix tox * Rebasing * fix
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step, beyond this we can: