[ci] Update ci config to reduce javascript test time and some of cypress. #6016
+63
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| npm run build | ||
| npm run cypress run --record | ||
| npm run cypress run |
There was a problem hiding this comment.
Is there a reason you removed --record? It doesn't work atm but I'm trying to get it to work, unless we think we don't want to use cypress dashboard.
There was a problem hiding this comment.
Was trying to make it work via npm run cypress run -- --record then cypress complains asking for --key, which is required for recording. Will leave this for @michellethomas to handle in future review.
williaster
approved these changes
Oct 4, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…ess. (apache#6016) * try travis config * try more complex config * fix config * add cache and stages * separate cache * swap order * fix redis * remove env * add cypress * adjust caching * reduce cache * change order of execution * change order again * change node version * install yarn via curl * update cypress command * update cypress command * adjust cache and node version * do not install yarn * add npm cache * remove export * remove commented code * change order of jobs * fix indent
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight: Reduce time to run javascript test from 8-10mins to 3-5 mins
Details
yarn install --frozen-lockfileinstead ofyarn installas recommended by travis.javascript test
language: node_jsfor the javascript test instead of running it via python.npm run testbecausenpm run coveralready run the test. Basically we have been running js test twice.npm run buildas the cypress test will always need to build. Seems redundant.cypress test
others
postgresonly for the tests that need postgres.@michellethomas @graceguo-supercat @mistercrunch @john-bodley