Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vis] Import only world map from datamaps #6029

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 4, 2018

Import only world map from datamaps instead of importing all maps by default.
Reduce the bundle size a bit. (142KB vs 114KB)

@williaster @conglei @graceguo-supercat

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥can merge once the build is fixed!

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #6029 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6029      +/-   ##
=========================================
+ Coverage   64.66%   64.7%   +0.04%     
=========================================
  Files         448     448              
  Lines       23773   23773              
  Branches     2639    2639              
=========================================
+ Hits        15373   15383      +10     
+ Misses       8387    8377      -10     
  Partials       13      13
Impacted Files Coverage Δ
...set/assets/src/visualizations/WorldMap/WorldMap.js 0% <0%> (ø) ⬆️
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ef0ae...f51fcb2. Read the comment docs.

@williaster williaster merged commit f889798 into apache:master Oct 4, 2018
@kristw kristw deleted the kristw-worldmap branch October 4, 2018 21:47
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants