Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename color constants and move util function into separate file #6074

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Rename color constants and move util function into separate file #6074

merged 2 commits into from
Oct 11, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 11, 2018

  • Rename color constants to UPPERCASE
  • Move isDefined function into its own file and add unit test
  isDefined(value)
    ✓ returns true if value is not null and not undefined
    ✓ returns false otherwise

@graceguo-supercat @williaster @conglei @michellethomas

@kristw kristw changed the title Rename color constants to UPPERCASE Rename color constants and move util function into separate file Oct 11, 2018
@codecov-io
Copy link

codecov-io commented Oct 11, 2018 •
edited
Loading

Codecov Report

Merging #6074 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6074   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files          47       47           
  Lines        9496     9496           
=======================================
  Hits         7368     7368           
  Misses       2128     2128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4cf85...e6eeb7a. Read the comment docs.

graceguo-supercat
graceguo-supercat approved these changes Oct 11, 2018
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit 64383ce into apache:master Oct 11, 2018
@kristw kristw deleted the kristw-color branch October 12, 2018 00:37
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@kristw @bipinsoniguavus
Rename color constants and move util function into separate file (apa…
12aa408 
…che#6074)

* rename constant colors to UPPERCASE

* Move isDefined into its own file and add unit test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristw @codecov-io @graceguo-supercat @mistercrunch