Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present. #12333

Closed
gashutos opened this issue May 25, 2023 · 1 comment
Closed

PagingFieldCollector is not able to skip documents for searchAfter value for which no competitive hits are present. #12333

gashutos opened this issue May 25, 2023 · 1 comment
Labels
type:bug
Milestone
9.7.0

Comments

@gashutos
Copy link
Contributor

Description

If we specify after value for PagingFieldCollector which is out of min/max values for that field in that segment, PagingFieldCollector is not able to update its competitiveIterator because queueFull is never able to set to true.
Code ref - NumericComparator.java$194

Due to this, it will spend lot of time comparing large number of hits here TopFieldCollector.java#264.
Instead it is supposed to short cut right away.

Version and environment details

No response
@gashutos gashutos mentioned this issue May 25, 2023
Merged
@gsmiller gsmiller added this to the 9.7.0 milestone May 31, 2023
@gsmiller
Copy link
Contributor

Thanks for the PR @gashutos! Merged and back-ported under 9.7.

@gashutos gashutos mentioned this issue Apr 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
9.7.0
Development

No branches or pull requests
2 participants
@gsmiller @gashutos