Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exceptions in SftpFileSystemProvider on Files.delete( Path p) #325

Closed
sijskes opened this issue Mar 2, 2023 · 4 comments · Fixed by #344
Closed

exceptions in SftpFileSystemProvider on Files.delete( Path p) #325

sijskes opened this issue Mar 2, 2023 · 4 comments · Fixed by #344
Assignees
@tomaswolf
Labels
bug An issue describing a bug in the code
Milestone
2.10

Comments

@sijskes
Copy link

sijskes commented Mar 2, 2023 •
edited
Loading

Version

sshd-sftp 2.9.2

Bug description

While using a Path on SftpFileSystemProvider:

Exceptions thrown in on Files.delete( Path p), when deleting symbolic links.

  • When deleting a symbolic links to non-existing file.
  • When deleting a symbolic link to existing directory
  • When deleting a symbolic link to existing file

Actual behavior

probably the links are followed, and the link is handled like the linkdestination. this causes exceptions.

Expected behavior

No exception but deletion of the symbolic link.

Relevant log output

No response

Other information

Server OpenSSH_8.9p1 Ubuntu-3ubuntu0.1
@sijskes
Copy link
Author

sijskes commented Mar 2, 2023 •
edited
Loading

delete of link to existing directory.

Caused by: org.apache.sshd.sftp.common.SftpException: No such file
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.throwStatusException(AbstractSftpClient.java:217)
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.checkResponseStatus(AbstractSftpClient.java:212)
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.checkResponseStatus(AbstractSftpClient.java:186)
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.checkCommandStatus(AbstractSftpClient.java:164)
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.rmdir(AbstractSftpClient.java:817)
	at org.apache.sshd.sftp.client.fs.SftpFileSystem$Wrapper.rmdir(SftpFileSystem.java:372)
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.delete(SftpFileSystemProvider.java:591)
	at java.base/java.nio.file.Files.delete(Files.java:1152)
	at nl.qcg.br.releaser.util.FileUtil.fixedFileDelete(FileUtil.java:135)
	at nl.qcg.br.releaser.cmds.comp.PathCopier.lambda$remove$3(PathCopier.java:181)
	... 19 common frames omitted


Path = usr/share/icons/Humanity-Dark/status@2

# ls -al usr/share/icons/Humanity-Dark/status@2
lrwxrwxrwx 1 root root 6 mrt 18  2022 'usr/share/icons/Humanity-Dark/status@2' -> status/
# ls -ald usr/share/icons/Humanity-Dark/status
drwxr-xr-x 1 root root 16 mrt  2 12:26 usr/share/icons/Humanity-Dark/status

@sijskes
Copy link
Author

sijskes commented Mar 2, 2023 •
edited
Loading

deleting an symbolic link pointing to a file

# ls -ald usr/share/icons/ubuntu-mono-light/stock/22/avatar-default.svg
lrwxrwxrwx 1 root root 22 mrt 18  2022 usr/share/icons/ubuntu-mono-light/stock/22/avatar-default.svg -> stock_person-panel.svg
# ls -ald usr/share/icons/ubuntu-mono-light/stock/22/stock_person-panel.svg
-rw-r--r-- 3 root root 2616 mrt 18  2022 usr/share/icons/ubuntu-mono-light/stock/22/stock_person-panel.svg

Caused by: java.nio.file.NoSuchFileException: usr/share/icons/ubuntu-mono-light/stock/22/avatar-default.svg
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.resolveRemoteFileAttributes(SftpFileSystemProvider.java:994)
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.lambda$readRemoteAttributes$0(SftpFileSystemProvider.java:969)
	at org.apache.sshd.sftp.client.impl.SftpPathImpl.withAttributeCache(SftpPathImpl.java:120)
	at org.apache.sshd.sftp.client.impl.SftpPathImpl.withAttributeCache(SftpPathImpl.java:140)
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.readRemoteAttributes(SftpFileSystemProvider.java:969)
	at org.apache.sshd.sftp.client.impl.AbstractSftpFileAttributeView.readRemoteAttributes(AbstractSftpFileAttributeView.java:71)
	at org.apache.sshd.sftp.client.fs.SftpPosixFileAttributeView.readAttributes(SftpPosixFileAttributeView.java:52)
	at org.apache.sshd.sftp.client.fs.SftpPosixFileAttributeView.readAttributes(SftpPosixFileAttributeView.java:40)
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.checkAccess(SftpFileSystemProvider.java:826)
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.delete(SftpFileSystemProvider.java:581)
	at java.base/java.nio.file.Files.delete(Files.java:1152)
	at nl.qcg.br.releaser.cmds.comp.PathCopier.lambda$remove$3(PathCopier.java:180)
	... 19 common frames omitted
Caused by: org.apache.sshd.sftp.common.SftpException: No such file
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.throwStatusException(AbstractSftpClient.java:217)
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.checkAttributesResponse(AbstractSftpClient.java:305)
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.checkAttributes(AbstractSftpClient.java:283)
	at org.apache.sshd.sftp.client.impl.AbstractSftpClient.stat(AbstractSftpClient.java:997)
	at org.apache.sshd.sftp.client.fs.SftpFileSystem$Wrapper.stat(SftpFileSystem.java:412)
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.resolveRemoteFileAttributes(SftpFileSystemProvider.java:981)
	... 30 common frames omitted

@sijskes
Copy link
Author

sijskes commented Mar 2, 2023

i can't reproduce the case with the symlink pointing to non-existing file anymore, but i pretty sure there was an exception as well.

@tomaswolf
Copy link
Member 

	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.checkAccess(SftpFileSystemProvider.java:826)
	at org.apache.sshd.sftp.client.fs.SftpFileSystemProvider.delete(SftpFileSystemProvider.java:581)
	at java.base/java.nio.file.Files.delete(Files.java:1152)

There is definitely a problem here. Files.delete() is specified not to follow symlinks, but SftpFileSystemProvider.checkAccess() does.

@tomaswolf tomaswolf self-assigned this Mar 19, 2023
@tomaswolf tomaswolf added the bug An issue describing a bug in the code label Mar 19, 2023
@tomaswolf tomaswolf added this to the 2.9.3 milestone Mar 19, 2023
tomaswolf added a commit to tomaswolf/mina-sshd that referenced this issue Mar 22, 2023
@tomaswolf
apacheGH-325: SFTP: fix deleting remote symbolic links
2dfeb5c 
Files.delete() is specified *not* to follow symbolic links. The
implementation in SftpFileSystemProvider checked for write access
and file existence via a method that does resolve symbolic links.
This lead to general inconsistency and various kinds of failures.

Fix this by making sure that the code does not resolve symbolic
links in Files.delete().

Bug: apache#325
tomaswolf added a commit to tomaswolf/mina-sshd that referenced this issue Mar 22, 2023
@tomaswolf
apacheGH-325: SFTP: fix deleting remote symbolic links
2e18d7c 
Files.delete() is specified *not* to follow symbolic links. The
implementation in SftpFileSystemProvider checked for write access
and file existence via a method that does resolve symbolic links.
This lead to general inconsistency and various kinds of failures.

Fix this by making sure that the code does not resolve symbolic
links in Files.delete().

Bug: apache#325
tomaswolf added a commit to tomaswolf/mina-sshd that referenced this issue Mar 22, 2023
@tomaswolf
apacheGH-325: SFTP: fix deleting remote symbolic links
b030b15 
Files.delete() is specified *not* to follow symbolic links. The
implementation in SftpFileSystemProvider checked for write access
and file existence via a method that does resolve symbolic links.
This lead to general inconsistency and various kinds of failures.

Fix this by making sure that the code does not resolve symbolic
links in Files.delete().

Bug: apache#325
@tomaswolf tomaswolf mentioned this issue Mar 22, 2023
Merged
tomaswolf added a commit to tomaswolf/mina-sshd that referenced this issue Mar 24, 2023
@tomaswolf
apacheGH-325: SFTP: fix deleting remote symbolic links
2779bbc 
Files.delete() is specified *not* to follow symbolic links. The
implementation in SftpFileSystemProvider checked for write access
and file existence via a method that does resolve symbolic links.
This lead to general inconsistency and various kinds of failures.

Fix this by making sure that the code does not resolve symbolic
links in Files.delete().

Bug: apache#325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaswolf tomaswolf

Labels
bug An issue describing a bug in the code
Projects
None yet
Milestone
2.10
Development

Successfully merging a pull request may close this issue.

GH-325: SFTP: fix deleting remote symbolic links tomaswolf/mina-sshd
2 participants
@sijskes @tomaswolf