From 5631c13b01859ddb93221a75862d493670a7e2bc Mon Sep 17 00:00:00 2001 From: Leonard Lausen Date: Wed, 29 Jan 2020 03:37:03 -0800 Subject: [PATCH] Simplify C++ flags (#17413) "Only add c++11 flags and definitions after cuda compiling" is not true anymore --- CMakeLists.txt | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 95d879895c6a..d6b348aea99f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -203,12 +203,15 @@ else() if(SUPPORT_CXX14) add_definitions(-DDMLC_USE_CXX11=1) add_definitions(-DDMLC_USE_CXX14=1) + add_definitions(-DMSHADOW_IN_CXX11) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14") elseif(SUPPORT_CXX11) add_definitions(-DDMLC_USE_CXX11=1) + add_definitions(-DMSHADOW_IN_CXX11) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11") elseif(SUPPORT_CXX0X) add_definitions(-DDMLC_USE_CXX11=1) + add_definitions(-DMSHADOW_IN_CXX11) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x") endif() endif(MSVC) @@ -671,13 +674,7 @@ if(USE_PLUGIN_CAFFE) endif() endif() -if(NOT MSVC) - # Only add c++11 flags and definitions after cuda compiling - add_definitions(-DDMLC_USE_CXX11) - add_definitions(-DMSHADOW_IN_CXX11) - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x") -else() +if(MSVC) set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /EHsc") set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /EHsc /Gy") set(CMAKE_CXX_FLAGS_MINSIZEREL "${CMAKE_CXX_FLAGS_MINSIZEREL} /EHsc /Gy")