-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Flaky test: test_gluon.test_hybrid_static_memory_switching #11171
Comments
Thanks for submitting this issue @ThomasDelteil |
@piiswrong you introduced this test in this commit [WIP] Do Not Merge. Static memory allocation for cached_op (#10817) 2dbd143 and it seems to be flaky. I have seen it failing a few times in recent builds. Can you take a look? e.g Given all the talk about quality contributions going on the dev mailing list, I am a little unsettled by the fact this PR went undocumented (no design docs or explanation in the PR), unreviewed (1 question ignored), the optimization wasn't tested or benchmarked (it was actually making slower), and the code was self-merged. Should we enforce that each PR , especially the ones that introduce a significant number of changes be properly documented and reviewed before merging? |
I ran the test thousands of times. It doesn't appear frequently. I checked core dumps. It seems they fail all exactly in the same place.
|
@TaoLv @pengzhao-intel @ashokei @azai91 Could you help check why it always fails in the same place? |
@zheng-da which |
it seems the error only happens in |
Does it only happen with MKLDNN or is it unrelated? |
If it's only related with MKLDNN, we will take over the issue. @marcoabreu @zheng-da |
@pengzhao-intel Looks like it only fails when using MKLDNN. Could you help take a look? |
@piiswrong @zheng-da I can reproduce the issue. Will do further investigation. |
|
|
Appreciate the investigation @pengzhao-intel @piiswrong. As a heads up, it looks like test_gluon.test_hybrid_static_memory is also failing. http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/1084/pipeline |
the problem should have been fixed by #11577 |
test_gluon.test_hybrid_static_memory_switching
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-11024/6/pipeline/
The text was updated successfully, but these errors were encountered: