Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Why no Codeowner for /cpp-package/? #9855

Closed
chsin opened this issue Feb 21, 2018 · 1 comment
Closed

Why no Codeowner for /cpp-package/? #9855

chsin opened this issue Feb 21, 2018 · 1 comment

Comments

@chsin
Copy link
Contributor

chsin commented Feb 21, 2018

Why isn't there a code owner for /cpp-package/ in CODEOWNERS?

# Language bindings
/R-package/       @thirdwing
/scala-package/   @yzhliu
/perl-package/    @sergeykolychev
/python/          @szha

It seems like it would be @lx75249 because of [Integrate cpp package #5251] and it looks like @lx75249 gets asked to review in PRs to /cpp-package/ e.g. #9220 and #7495. Having a code owner is important PRs since some PRs can't be merged without having someone who is familiar with the package to review even if someone else actually reviews the code and all the code-owner has to do is write LGTM.

@szha
Copy link
Member

szha commented Feb 21, 2018

We use github codeowner feature just as a way to subscribe to pull requests.

@chsin chsin closed this as completed Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants