Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: Remove native create support for file? #1429

Closed
Xuanwo opened this issue Feb 28, 2023 · 6 comments
Closed

idea: Remove native create support for file? #1429

Xuanwo opened this issue Feb 28, 2023 · 6 comments
Assignees

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Feb 28, 2023

  • Not all service supports create empty file.
  • This feature is overlap with o.write("")
@suyanhanx
Copy link
Member

We may append some new APIs together to retain the ability to operate folders like

  • op.create_dir("xxx")
  • op.remove_all("xxx")

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 8, 2023

LGTM, I think we can rename create to create_dir and remove the create file support. @suyanhanx Do you want to take this issue?

@suyanhanx
Copy link
Member

Yes. Please count me in.

@suyanhanx
Copy link
Member

Does it look like we can handle all services which's create method that mixes files and directories?

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 8, 2023

Does it look like we can handle all services which's create method that mixes files and directories?

We can change the outer public API first and change the services implementation later. I expect to release v0.30 after public API changed.

@suyanhanx
Copy link
Member

suyanhanx commented Mar 8, 2023

We can change the outer public API first and change the services implementation later. I expect to release v0.30 after public API changed.

SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants