New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binding/nodejs: dotenv should not be used in production code #3576

Closed

Xuanwo opened this issue Nov 13, 2023 · 0 comments · Fixed by #3579

Labels

bindings/nodejs good first issue help wanted

Member

Xuanwo commented Nov 13, 2023

https://github.com/apache/incubator-opendal/blob/bec1e9db5effb99fe1d369941f6e04036fb2ec99/bindings/nodejs/index.js#L22

It's wrong that dotenv is used in production code, we should remove it.

Xuanwo added bindings/nodejs good first issue help wanted labels

AlexVCS mentioned this issue

chore: removed dotenv in bindings/nodejs/index.js #3579

Merged

Xuanwo closed this as completed in #3579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment