Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose write_with method for Node.js binding #4782

Closed
syhily opened this issue Jun 21, 2024 · 4 comments · Fixed by #4785
Closed

Expose write_with method for Node.js binding #4782

syhily opened this issue Jun 21, 2024 · 4 comments · Fixed by #4785
Assignees
@bxb100
Labels
bindings/nodejs good first issue Good for newcomers help wanted Extra attention is needed

Comments

@syhily
Copy link

syhily commented Jun 21, 2024

Currently, the write_with method doesn't get properly exposed in Node.js binding.
@Xuanwo Xuanwo added good first issue Good for newcomers bindings/nodejs help wanted Extra attention is needed labels Jun 21, 2024
@bxb100
Copy link
Contributor

bxb100 commented Jun 21, 2024

@Xuanwo I want to do this

@Xuanwo
Copy link
Member

Xuanwo commented Jun 21, 2024

@Xuanwo I want to do this

Thanks a lot, have fun!

@bxb100 bxb100 mentioned this issue Jun 22, 2024
Merged
@Xuanwo Xuanwo closed this as completed in 591d034 Jun 24, 2024
@bxb100 bxb100 mentioned this issue Jun 24, 2024
Merged
@syhily
Copy link
Author

syhily commented Jun 26, 2024

Happy to see it was resolved. When can we get this feature released?

@Xuanwo
Copy link
Member

Xuanwo commented Jun 26, 2024 •
edited
Loading

Happy to see it was resolved. When can we get this feature released?

I plan to have a release in next week: https://lists.apache.org/thread/prsnhgyv0zhzqjdl3wwdky4n3f12m1tp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bxb100 bxb100

Labels
bindings/nodejs good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nodejs): add WriteOptions for write methods
3 participants
@syhily @Xuanwo @bxb100