Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose config struct always #5033

Closed
tisonkun opened this issue Aug 22, 2024 · 1 comment · Fixed by #5034
Closed

Expose config struct always #5033

tisonkun opened this issue Aug 22, 2024 · 1 comment · Fixed by #5034

Comments

@tisonkun
Copy link
Member

Now all the backend services has an associated Config type.

In my project I'd prefer to extra all the config into a separated crate (protos) and keep it as thin as enough, i.e., I need:

  • Refer to configs said S3Config;
  • Without refer to the whole S3 backend.

The config will later pass to the service crate and really initialize the backend (within the operator). And in this way in the protos crate I can depend on opendal = { version = ".." } without any features.

@Xuanwo what do you think?

@Xuanwo
Copy link
Member

Xuanwo commented Aug 22, 2024

a separated crate (protos)

A separate crate might not work since we need to implement Configurator, which is highly coupled to its Builder. Maybe we can expose it in a new module like opendal::services::S3Config by placing it in services/s3_config.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants