New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary namespace prefixes in code #529

Closed

ClSlaid opened this issue Aug 16, 2022 · 6 comments · Fixed by #560

Assignees

Labels

good first issue help wanted

Contributor

ClSlaid commented Aug 16, 2022 •

edited

Loading

Though already imported
https://github.com/datafuselabs/opendal/blob/7848fbc17ef60765aef6c9026566a356cec64fa3/src/services/gcs/backend.rs#L25
Some unnecessary namespace prefixes are still represented in the code
https://github.com/datafuselabs/opendal/blob/7848fbc17ef60765aef6c9026566a356cec64fa3/src/services/gcs/backend.rs#L434
https://github.com/datafuselabs/opendal/blob/7848fbc17ef60765aef6c9026566a356cec64fa3/src/services/gcs/backend.rs#L452

Originally raised by @ClSlaid in #526 (comment)

Xuanwo added good first issue help wanted labels

Contributor

teckick commented Aug 23, 2022

/assignme

Xuanwo assigned teckick

teckick mentioned this issue

refactor: Remove all unused qualifications #560

Merged

Xuanwo closed this as completed in #560

Contributor

teckick commented Aug 24, 2022 •

edited

Loading

Lint error is found, but the lint does not warn. Looks strange.

cargo clippy --workspace --all-targets --all-features -- -D warnings

https://github.com/datafuselabs/opendal/blob/main/src/services/obs/backend.rs#L347

Contributor

teckick commented Aug 24, 2022

Issue submitted rust-lang/rust-clippy#9372

Contributor

teckick commented Aug 24, 2022 •

edited

Loading

Please keep this issue open before all lint errors are fixed.

Xuanwo reopened this

Member

Xuanwo commented Aug 25, 2022

Updated rust-lang/rust#100979

Member

Xuanwo commented Aug 31, 2022

I prefer to close this issue now. We need to wait for rust.

If rust has fixed this, we will see the warning again. And until then, we will fix this.

Xuanwo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment