Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace legacy kubectl commands with rest-client in kube client. #3857

Closed
tz70s opened this issue Jul 9, 2018 · 2 comments
Closed

Replace legacy kubectl commands with rest-client in kube client. #3857

tz70s opened this issue Jul 9, 2018 · 2 comments

Comments

@tz70s
Copy link
Contributor

tz70s commented Jul 9, 2018 •
edited
Loading

In the kubernetes client apis, there still exist the legacy kubectl commands.
https://github.com/apache/incubator-openwhisk/blob/5b13c4c90e4f8d59156c862c2ffe57ef027e5aee/core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala#L168-L174

It's better to replace this with rest-client based on fabric8.
@tz70s
Copy link
Contributor Author

tz70s commented Jul 9, 2018

Currently, the kubernetes client tests are made by mock client with limited number of test cases. After removing kubectl commands, we can refactor our tests with more comprehensive test cases by using mock kubernetes server.

@dgrove-oss
Copy link
Member

Done 4 months ago in #3963 but I forgot to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgrove-oss @tz70s