Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust PR template to reference GitHub issue tracker #2932

Closed
rok opened this issue Jun 24, 2024 · 5 comments
Closed

Adjust PR template to reference GitHub issue tracker #2932

rok opened this issue Jun 24, 2024 · 5 comments
Assignees

Comments

@rok
Copy link
Member

rok commented Jun 24, 2024

Now that we moved issue tracking to GitHub we should adjust our pull request template.

@rok rok changed the title Adjust PR template to GitHub issue tracker Adjust PR template to reference GitHub issue tracker Jun 24, 2024
@wgtmac
Copy link
Member

wgtmac commented Jun 24, 2024

I'm not sure it is a good idea to copy https://github.com/apache/arrow/blob/main/dev/merge_arrow_pr.py so we can automatically close related issue while merging PRs.

@rok
Copy link
Member Author

rok commented Jun 24, 2024

I wonder if we could avoid the script and just use the merge button?
@raulcd Why is Arrow currently using the script instead of the button?

@rok rok closed this as completed Jun 24, 2024
@raulcd
Copy link
Member

raulcd commented Jun 25, 2024

The merge script still does several issues like, validate the milestone is set correctly, updating the Title name, authors, setting the correct lables if necessary.
We could investigate if some of those issues could be automated when merging with the merge button but the one I am not entirely sure how we would like to do is the milestone validation and setting we do before merging.

@rok
Copy link
Member Author

rok commented Jun 25, 2024

That sounds like we probably don't want to use the merge button then.
For automated closing of connected issues after merges we could use github automation.

@wgtmac
Copy link
Member

wgtmac commented Jun 25, 2024

That sounds like we probably don't want to use the merge button then. For automated closing of connected issues after merges we could use github automation.

Sounds good. There are always new stuffs to learn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants