Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2476: Remove the maven-compiler override #1341

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented May 2, 2024

The Apache POM is now at 3.13.0 after #1333

Less is more!

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

The Apache POM is now at 3.13.0 after #1333
@wgtmac
Copy link
Member

wgtmac commented May 3, 2024

Should we create a JIRA for this?

@wgtmac wgtmac changed the title Remove the maven-compiler override PARQUET-2476: Remove the maven-compiler override May 16, 2024
@wgtmac wgtmac merged commit b7005f5 into master May 16, 2024
18 checks passed
clairemcginty pushed a commit to clairemcginty/parquet-mr that referenced this pull request May 17, 2024
@Fokko Fokko deleted the fd-remove-override branch July 17, 2024 06:30
@wgtmac wgtmac added this to the 1.15.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants