GH-2952: Add maven wrapper #2953
Conversation
|
As a next step (please let me know if that should be within this PR) I was planning to update all |
|
This looks nice. However, my concern is the maintenance burden of the new script. @julienledem @gszadovszky WDYT? |
|
Missing mvnw.cmd |
@wgtmac typically this script doesn't require any maintenance and will be updated automatically when updating the underlying maven version through the wrapper. That doesn't mean that every maven version bump requires an updated script, just that the wrapper task will update the script if necessary |
| # ---------------------------------------------------------------------------- | ||
|
|
||
| # ---------------------------------------------------------------------------- | ||
| # Apache Maven Wrapper startup batch script, version 3.3.2 |
There was a problem hiding this comment.
Is it copied from somewhere else? It would be good if a link is provided so we can keep it updated.
There was a problem hiding this comment.
no, it's being generated and will be automatically updated (if necessary) when updating the underlying maven version of the wrapper
There was a problem hiding this comment.
if you run mvn wrapper:wrapper against master you'll get the same scripts generated
* apacheGH-2952: Add maven wrapper * Update mvn references to ./mvnw
Rationale for this change
Having a maven wrapper in the project removes the burden for users to have maven installed on their system.
The wrapper was added by running
mvn wrapper:wrapperWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?