Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2976: Parqurt CLI compression commands should accept lowercase compression name #2977

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Aug 1, 2024

Rationale for this change

Currently, there is inconsistent in different commands.

$ parquet convert c000.snappy.parquet -o c000.zstd.parquet --compression-codec zstd
$ parquet rewrite -i c000.snappy.parquet -o c000.zstd.parquet --compression-codec zstd
Argument error: No enum constant org.apache.parquet.hadoop.metadata.CompressionCodecName.zstd

For consistent user experience of Parquet CLI, we should allow lowercase codecs in all commands.

What changes are included in this PR?

Change Parquet CLI's trans-compression and rewrite commands to accept lowercase compression codec.

Are these changes tested?

Yes, new UTs are added.

Are there any user-facing changes?

Yes.

Close #2976

@wgtmac wgtmac merged commit fd82995 into apache:master Aug 7, 2024
9 checks passed
@wgtmac wgtmac added this to the 1.15.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parqurt CLI compression commands should accept lowercase compression name
2 participants