From 2a258a6369181380bbd128033542d61eae52f8ef Mon Sep 17 00:00:00 2001 From: Soumitra Kumar Date: Sun, 23 Jun 2024 14:11:59 -0700 Subject: [PATCH 1/7] Adding registerExtraComponents to allow registering additional components in various services --- .../pinot/broker/broker/BrokerAdminApiApplication.java | 4 ++++ .../controller/api/ControllerAdminApiApplication.java | 4 ++++ .../org/apache/pinot/minion/BaseMinionStarter.java | 10 ++++++++++ .../apache/pinot/minion/MinionAdminApiApplication.java | 4 ++++ .../apache/pinot/server/api/AdminApiApplication.java | 4 ++++ .../pinot/server/starter/helix/BaseServerStarter.java | 10 ++++++++++ 6 files changed, 36 insertions(+) diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerAdminApiApplication.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerAdminApiApplication.java index 8dedc8c72b3b..b204dcd4350e 100644 --- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerAdminApiApplication.java +++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerAdminApiApplication.java @@ -162,4 +162,8 @@ public void stop() { LOGGER.info("Shutting down executor service"); _executorService.shutdownNow(); } + + public HttpServer getHttpServer() { + return _httpServer; + } } diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java b/pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java index b04e6a75d97d..978777661f9c 100644 --- a/pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java +++ b/pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java @@ -122,4 +122,8 @@ public void filter(ContainerRequestContext containerRequestContext, } } } + + public HttpServer getHttpServer() { + return _httpServer; + } } diff --git a/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java b/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java index 6ad1140d0d1b..bec14a36102b 100644 --- a/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java +++ b/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java @@ -281,6 +281,7 @@ public void start() minionContext.setHelixManager(_helixManager); LOGGER.info("Starting minion admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); _minionAdminApplication = new MinionAdminApiApplication(_instanceId, _config); + registerExtraComponents(_minionAdminApplication); _minionAdminApplication.start(_listenerConfigs); // Initialize health check callback @@ -347,4 +348,13 @@ public void stop() { } LOGGER.info("Pinot minion stopped"); } + + /** + * This method is called after initialization of BrokerAdminApiApplication object + * and before calling start to allow custom broker starters to register additional + * components. + * @param minionAdminApiApplication is the application + */ + protected void registerExtraComponents(MinionAdminApiApplication minionAdminApiApplication) { + } } diff --git a/pinot-minion/src/main/java/org/apache/pinot/minion/MinionAdminApiApplication.java b/pinot-minion/src/main/java/org/apache/pinot/minion/MinionAdminApiApplication.java index 9e8ce9571335..25fd9573298a 100644 --- a/pinot-minion/src/main/java/org/apache/pinot/minion/MinionAdminApiApplication.java +++ b/pinot-minion/src/main/java/org/apache/pinot/minion/MinionAdminApiApplication.java @@ -95,4 +95,8 @@ public void stop() { _httpServer.shutdownNow(); } } + + public HttpServer getHttpServer() { + return _httpServer; + } } diff --git a/pinot-server/src/main/java/org/apache/pinot/server/api/AdminApiApplication.java b/pinot-server/src/main/java/org/apache/pinot/server/api/AdminApiApplication.java index 520b95cf064e..3c959e3ecd59 100644 --- a/pinot-server/src/main/java/org/apache/pinot/server/api/AdminApiApplication.java +++ b/pinot-server/src/main/java/org/apache/pinot/server/api/AdminApiApplication.java @@ -141,4 +141,8 @@ public void startShuttingDown() { public void stop() { _httpServer.shutdownNow(); } + + public HttpServer getHttpServer() { + return _httpServer; + } } diff --git a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java index e1d78a88f547..d7567d29e0a0 100644 --- a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java +++ b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java @@ -618,6 +618,7 @@ public void start() // Start restlet server for admin API endpoint LOGGER.info("Starting server admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); _adminApiApplication = new AdminApiApplication(_serverInstance, accessControlFactory, _serverConf); + registerExtraComponents(_adminApiApplication); _adminApiApplication.start(_listenerConfigs); // Init QueryRewriterFactory @@ -931,4 +932,13 @@ private void initSegmentFetcher(PinotConfiguration config) PinotConfiguration pinotCrypterConfig = config.subset(CommonConstants.Server.PREFIX_OF_CONFIG_OF_PINOT_CRYPTER); PinotCrypterFactory.init(pinotCrypterConfig); } + + /** + * This method is called after initialization of BrokerAdminApiApplication object + * and before calling start to allow custom broker starters to register additional + * components. + * @param adminApiApplication is the application + */ + protected void registerExtraComponents(AdminApiApplication adminApiApplication) { + } } From ed8b5b0c4aa8f5bc78b6977545c0c45ac1482de1 Mon Sep 17 00:00:00 2001 From: Soumitra Kumar Date: Mon, 24 Jun 2024 14:45:54 -0700 Subject: [PATCH 2/7] Added createXAdminApp method for Broker, Controller, Minion and Server --- .../broker/broker/helix/BaseBrokerStarter.java | 10 +++++++--- .../controller/BaseControllerStarter.java | 6 +++++- .../apache/pinot/minion/BaseMinionStarter.java | 12 +++--------- .../starter/helix/BaseServerStarter.java | 18 ++++++------------ 4 files changed, 21 insertions(+), 25 deletions(-) diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java index b16489b35bb3..527ceb9caa6a 100644 --- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java +++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java @@ -346,9 +346,7 @@ public void start() _sqlQueryExecutor = new SqlQueryExecutor(_spectatorHelixManager); } LOGGER.info("Starting broker admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); - _brokerAdminApplication = - new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, - _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); + _brokerAdminApplication = getBrokerAdminApp(); registerExtraComponents(_brokerAdminApplication); _brokerAdminApplication.start(_listenerConfigs); @@ -413,6 +411,7 @@ public void start() } /** + * @deprecated Use {@link #getBrokerAdminApp()} instead. * This method is called after initialization of BrokerAdminApiApplication object * and before calling start to allow custom broker starters to register additional * components. @@ -600,4 +599,9 @@ public AccessControlFactory getAccessControlFactory() { public BrokerRequestHandler getBrokerRequestHandler() { return _brokerRequestHandler; } + + protected BrokerAdminApiApplication getBrokerAdminApp() { + return new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, + _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); + } } diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java b/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java index 43c177a32613..2b8ea555bd3d 100644 --- a/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java +++ b/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java @@ -240,7 +240,7 @@ public void init(PinotConfiguration pinotConfiguration) // Initialize FunctionRegistry before starting the admin application (PinotQueryResource requires it to compile // queries) FunctionRegistry.init(); - _adminApp = new ControllerAdminApiApplication(_config); + _adminApp = createControllerAdminApp(); // Do not use this before the invocation of {@link PinotHelixResourceManager::start()}, which happens in {@link // ControllerStarter::start()} _helixResourceManager = new PinotHelixResourceManager(_config); @@ -927,4 +927,8 @@ public PinotMetricsRegistry getMetricsRegistry() { public ControllerMetrics getControllerMetrics() { return _controllerMetrics; } + + protected ControllerAdminApiApplication createControllerAdminApp() { + return new ControllerAdminApiApplication(_config); + } } diff --git a/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java b/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java index bec14a36102b..3ddd2b14728b 100644 --- a/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java +++ b/pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java @@ -280,8 +280,7 @@ public void start() minionContext.setHelixPropertyStore(_helixManager.getHelixPropertyStore()); minionContext.setHelixManager(_helixManager); LOGGER.info("Starting minion admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); - _minionAdminApplication = new MinionAdminApiApplication(_instanceId, _config); - registerExtraComponents(_minionAdminApplication); + _minionAdminApplication = createMinionAdminApp(); _minionAdminApplication.start(_listenerConfigs); // Initialize health check callback @@ -349,12 +348,7 @@ public void stop() { LOGGER.info("Pinot minion stopped"); } - /** - * This method is called after initialization of BrokerAdminApiApplication object - * and before calling start to allow custom broker starters to register additional - * components. - * @param minionAdminApiApplication is the application - */ - protected void registerExtraComponents(MinionAdminApiApplication minionAdminApiApplication) { + protected MinionAdminApiApplication createMinionAdminApp() { + return new MinionAdminApiApplication(_instanceId, _config); } } diff --git a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java index d7567d29e0a0..a075d84ecdc3 100644 --- a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java +++ b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java @@ -139,6 +139,7 @@ public abstract class BaseServerStarter implements ServiceStartable { protected HelixManager _helixManager; protected HelixAdmin _helixAdmin; protected ServerInstance _serverInstance; + protected AccessControlFactory _accessControlFactory; protected AdminApiApplication _adminApiApplication; protected ServerQueriesDisabledTracker _serverQueriesDisabledTracker; protected RealtimeLuceneIndexRefreshState _realtimeLuceneIndexRefreshState; @@ -572,9 +573,8 @@ public void start() String accessControlFactoryClass = _serverConf.getProperty(Server.ACCESS_CONTROL_FACTORY_CLASS, Server.DEFAULT_ACCESS_CONTROL_FACTORY_CLASS); LOGGER.info("Using class: {} as the AccessControlFactory", accessControlFactoryClass); - AccessControlFactory accessControlFactory; try { - accessControlFactory = PluginManager.get().createInstance(accessControlFactoryClass); + _accessControlFactory = PluginManager.get().createInstance(accessControlFactoryClass); } catch (Exception e) { throw new RuntimeException( "Caught exception while creating new AccessControlFactory instance using class '" + accessControlFactoryClass @@ -593,7 +593,7 @@ public void start() ServerSegmentCompletionProtocolHandler.init( _serverConf.subset(SegmentCompletionProtocol.PREFIX_OF_CONFIG_OF_SEGMENT_UPLOADER)); ServerConf serverConf = new ServerConf(_serverConf); - _serverInstance = new ServerInstance(serverConf, _helixManager, accessControlFactory); + _serverInstance = new ServerInstance(serverConf, _helixManager, _accessControlFactory); ServerMetrics serverMetrics = _serverInstance.getServerMetrics(); InstanceDataManager instanceDataManager = _serverInstance.getInstanceDataManager(); @@ -617,8 +617,7 @@ public void start() // Start restlet server for admin API endpoint LOGGER.info("Starting server admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); - _adminApiApplication = new AdminApiApplication(_serverInstance, accessControlFactory, _serverConf); - registerExtraComponents(_adminApiApplication); + _adminApiApplication = createServerApp(); _adminApiApplication.start(_listenerConfigs); // Init QueryRewriterFactory @@ -933,12 +932,7 @@ private void initSegmentFetcher(PinotConfiguration config) PinotCrypterFactory.init(pinotCrypterConfig); } - /** - * This method is called after initialization of BrokerAdminApiApplication object - * and before calling start to allow custom broker starters to register additional - * components. - * @param adminApiApplication is the application - */ - protected void registerExtraComponents(AdminApiApplication adminApiApplication) { + protected AdminApiApplication createServerApp() { + return new AdminApiApplication(_serverInstance, _accessControlFactory, _serverConf); } } From ba2d927247dd6511bbe5f37ba8f72a9259240d62 Mon Sep 17 00:00:00 2001 From: Soumitra Kumar Date: Mon, 24 Jun 2024 16:25:09 -0700 Subject: [PATCH 3/7] Fixed method name --- .../apache/pinot/broker/broker/helix/BaseBrokerStarter.java | 6 +++--- .../pinot/server/starter/helix/BaseServerStarter.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java index 527ceb9caa6a..fc22c7c9fbb7 100644 --- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java +++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java @@ -346,7 +346,7 @@ public void start() _sqlQueryExecutor = new SqlQueryExecutor(_spectatorHelixManager); } LOGGER.info("Starting broker admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); - _brokerAdminApplication = getBrokerAdminApp(); + _brokerAdminApplication = createBrokerAdminApp(); registerExtraComponents(_brokerAdminApplication); _brokerAdminApplication.start(_listenerConfigs); @@ -411,7 +411,7 @@ public void start() } /** - * @deprecated Use {@link #getBrokerAdminApp()} instead. + * @deprecated Use {@link #createBrokerAdminApp()} instead. * This method is called after initialization of BrokerAdminApiApplication object * and before calling start to allow custom broker starters to register additional * components. @@ -600,7 +600,7 @@ public BrokerRequestHandler getBrokerRequestHandler() { return _brokerRequestHandler; } - protected BrokerAdminApiApplication getBrokerAdminApp() { + protected BrokerAdminApiApplication createBrokerAdminApp() { return new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); } diff --git a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java index a075d84ecdc3..b961582a9e27 100644 --- a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java +++ b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java @@ -617,7 +617,7 @@ public void start() // Start restlet server for admin API endpoint LOGGER.info("Starting server admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); - _adminApiApplication = createServerApp(); + _adminApiApplication = createServerAdminApp(); _adminApiApplication.start(_listenerConfigs); // Init QueryRewriterFactory @@ -932,7 +932,7 @@ private void initSegmentFetcher(PinotConfiguration config) PinotCrypterFactory.init(pinotCrypterConfig); } - protected AdminApiApplication createServerApp() { + protected AdminApiApplication createServerAdminApp() { return new AdminApiApplication(_serverInstance, _accessControlFactory, _serverConf); } } From f34a5bb618f7b5340ebe6d3ff3a16cef06d3f6d8 Mon Sep 17 00:00:00 2001 From: Soumitra Kumar Date: Mon, 24 Jun 2024 22:21:37 -0700 Subject: [PATCH 4/7] Fixed typo in method name --- .../apache/pinot/broker/broker/helix/BaseBrokerStarter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java index fc22c7c9fbb7..8ad03b9ab196 100644 --- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java +++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java @@ -346,7 +346,7 @@ public void start() _sqlQueryExecutor = new SqlQueryExecutor(_spectatorHelixManager); } LOGGER.info("Starting broker admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); - _brokerAdminApplication = createBrokerAdminApp(); + _brokerAdminApplication = createBrokerAdminApi(); registerExtraComponents(_brokerAdminApplication); _brokerAdminApplication.start(_listenerConfigs); @@ -411,7 +411,7 @@ public void start() } /** - * @deprecated Use {@link #createBrokerAdminApp()} instead. + * @deprecated Use {@link #createBrokerAdminApi()} instead. * This method is called after initialization of BrokerAdminApiApplication object * and before calling start to allow custom broker starters to register additional * components. @@ -600,7 +600,7 @@ public BrokerRequestHandler getBrokerRequestHandler() { return _brokerRequestHandler; } - protected BrokerAdminApiApplication createBrokerAdminApp() { + protected BrokerAdminApiApplication createBrokerAdminApi() { return new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); } From c489f9719301cdfb32083284b49796886d82510f Mon Sep 17 00:00:00 2001 From: Soumitra Kumar Date: Tue, 25 Jun 2024 19:02:34 -0700 Subject: [PATCH 5/7] Fixed typo in method name --- .../apache/pinot/broker/broker/helix/BaseBrokerStarter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java index 8ad03b9ab196..fc22c7c9fbb7 100644 --- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java +++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java @@ -346,7 +346,7 @@ public void start() _sqlQueryExecutor = new SqlQueryExecutor(_spectatorHelixManager); } LOGGER.info("Starting broker admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); - _brokerAdminApplication = createBrokerAdminApi(); + _brokerAdminApplication = createBrokerAdminApp(); registerExtraComponents(_brokerAdminApplication); _brokerAdminApplication.start(_listenerConfigs); @@ -411,7 +411,7 @@ public void start() } /** - * @deprecated Use {@link #createBrokerAdminApi()} instead. + * @deprecated Use {@link #createBrokerAdminApp()} instead. * This method is called after initialization of BrokerAdminApiApplication object * and before calling start to allow custom broker starters to register additional * components. @@ -600,7 +600,7 @@ public BrokerRequestHandler getBrokerRequestHandler() { return _brokerRequestHandler; } - protected BrokerAdminApiApplication createBrokerAdminApi() { + protected BrokerAdminApiApplication createBrokerAdminApp() { return new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); } From 7a17921ceb41d7454908d857d7cabf384cb5f025 Mon Sep 17 00:00:00 2001 From: Soumitra Kumar Date: Tue, 25 Jun 2024 19:06:10 -0700 Subject: [PATCH 6/7] Moved registerExtraComponents in createBrokerAdminApp method --- .../apache/pinot/broker/broker/helix/BaseBrokerStarter.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java index fc22c7c9fbb7..353a893ceafd 100644 --- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java +++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java @@ -347,7 +347,6 @@ public void start() } LOGGER.info("Starting broker admin application on: {}", ListenerConfigUtil.toString(_listenerConfigs)); _brokerAdminApplication = createBrokerAdminApp(); - registerExtraComponents(_brokerAdminApplication); _brokerAdminApplication.start(_listenerConfigs); LOGGER.info("Initializing cluster change mediator"); @@ -601,7 +600,9 @@ public BrokerRequestHandler getBrokerRequestHandler() { } protected BrokerAdminApiApplication createBrokerAdminApp() { - return new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, + BrokerAdminApiApplication brokerAdminApiApplication = new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); + registerExtraComponents(brokerAdminApiApplication); + return brokerAdminApiApplication; } } From 19c8078bb54ef029f7a7255e1900bba61800f570 Mon Sep 17 00:00:00 2001 From: Soumitra Kumar Date: Tue, 25 Jun 2024 21:12:28 -0700 Subject: [PATCH 7/7] Fixed checkstyle violation --- .../apache/pinot/broker/broker/helix/BaseBrokerStarter.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java index 353a893ceafd..4fce735b7437 100644 --- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java +++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java @@ -600,8 +600,9 @@ public BrokerRequestHandler getBrokerRequestHandler() { } protected BrokerAdminApiApplication createBrokerAdminApp() { - BrokerAdminApiApplication brokerAdminApiApplication = new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, - _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); + BrokerAdminApiApplication brokerAdminApiApplication = + new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf, + _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory, _spectatorHelixManager); registerExtraComponents(brokerAdminApiApplication); return brokerAdminApiApplication; }