Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials provided or generated when bootstrapping should not be rotated #801

Open
adutra opened this issue Jan 16, 2025 · 2 comments
Open
Labels
bug Something isn't working

Comments

@adutra
Copy link
Contributor

adutra commented Jan 16, 2025

Describe the bug

When bootstrapping a realm, either with the env var POLARIS_BOOTSTRAP_CREDENTIALS or using the admin tool, the provided secrets get rotated.

Because previous secrets are still valid, this works, but I would argue that that's a bad user experience: the user said they want secret A, and they get secret B, and it's B that gets printed to stdout (for in-memory metastores).

What is the reason for doing this rotation?

  • If the secrets were randomly generated, rotating is meaningless
  • If the secrets were provided by the user, rotating effectively overrides their instructions.

To Reproduce

No response

Actual Behavior

No response

Expected Behavior

No response

Additional context

No response

System information

No response

@adutra adutra added the bug Something isn't working label Jan 16, 2025
@eric-maynard
Copy link
Contributor

@collado-mike, I recall we discussed this in my PR to use credential hashes

@collado-mike
Copy link
Contributor

I don't recall the discussion, but I think that if the secrets are provided via env variables, they should not be rotated except by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants