Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send message back error when client version > 3.4.9 #229

Closed
ShannonDing opened this issue Jan 14, 2020 · 0 comments · Fixed by #230
Closed

Send message back error when client version > 3.4.9 #229

ShannonDing opened this issue Jan 14, 2020 · 0 comments · Fixed by #230
Assignees
@ShannonDing
Labels
enhancement New feature or request
Milestone
1.2.5

Comments

@ShannonDing
Copy link
Member

for broker:
int maxReconsumeTimes = subscriptionGroupConfig.getRetryMaxTimes();
if (request.getVersion() >= MQVersion.Version.V3_4_9.ordinal()) {
maxReconsumeTimes = requestHeader.getMaxReconsumeTimes();
}

it need add maxReconsumeTimes in the protocol
maxReconsumeTimes
@ShannonDing ShannonDing self-assigned this Jan 14, 2020
@ShannonDing ShannonDing added the enhancement New feature or request label Jan 14, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 14, 2020
@ShannonDing ShannonDing changed the title Send message back error when client version > 3.5.9 Send message back error when client version > 3.4.9 Jan 14, 2020
@ShannonDing ShannonDing mentioned this issue Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShannonDing ShannonDing

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.5
Development

Successfully merging a pull request may close this issue.

feat(version): add maxConsumerTimes to support higher client version ShannonDing/rocketmq-client-cpp
1 participant
@ShannonDing