-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Support for Block Comment Style for Python files #7547
Comments
@mikhail-dr IIRC Python doesn't allow multi line comments, do you mean docstring? |
@kezhenxu94 yes, correct, docstrings, |
Could do share which project uses this style? |
we'd like to use |
Hi, my question is which? Is recommended in any Python doc or project? If so, it is reasonable to accept this. |
well, this was just an internal preference, to use docstring |
@kezhenxu94 I noticed no doc on https://hub.docker.com/r/apache/skywalking-eyes. Could you update it? |
@wu-sheng do you mean to say that it is already somehow possible to override the default |
I think we should have at least. We have this similar feature in other images, same for this too. Let's wait for @kezhenxu94 's confirmation. We are closing to eye 0.2.0. Let's see. |
@kezhenxu94 any further comments/updates on this? thanks. |
@mikhail-dr those files |
ok, thanks. |
@mikhail-dr Thanks to @dongzl 's apache/skywalking-eyes#97 and my apache/skywalking-eyes#100 , now you can configure the comment style like this 👇 to use DocString style header: # `header` section is configurations for source codes license header.
# ... other configurations
language:
Python:
extensions:
- ".py"
comment_style_id: PythonDocStringStyle
|
Please answer these questions before submitting your issue.
Question
There does not appear to be any way to configure the tool to use block comment for the insertion of copyright notice into Python files? The only way I can use block comments for that is if I modify
styles.yaml
andlanguages.yaml
files?Bug
Which version of SkyWalking, OS, and JRE?
Which company or project?
What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
Requirement or improvement
#
inline comments to insert copyright notices into Python files. It would be great if such possibility or config option were available in the tool.The text was updated successfully, but these errors were encountered: