Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “.exe” suffix to the Windows compiled executable program for skywalking-eyes #7845

Closed
kezhenxu94 opened this issue Sep 30, 2021 Discussed in #7844 · 4 comments · Fixed by apache/skywalking-eyes#101
Labels
bug Something isn't working and you are sure it's a bug! license eye

Comments

@kezhenxu94
Copy link
Member

Discussed in #7844

Originally posted by codeglzhang September 30, 2021
In skywalking-infra-e2e, we can use make build to get a Windows executable program skywalking-eyes\bin\windows\license-eye. However, in the command line of Windows, whether the file is an executable program is determined by whether the file has a specific suffix, such as ".exe". Thus, commands such as bin/darwin/license-eye -c test/testdata/.licenserc_for_test_fix.yaml header check will not be executed correctly under Windows.
image
After renaming the file skywalking-eyes\bin\windows\license-eye to skywalking-eyes\bin\windows\license-eye.exe, the command is executed.
image
The same is true for skywalking-infra-e2e.

@kezhenxu94 kezhenxu94 added bug Something isn't working and you are sure it's a bug! license eye infra-e2e Issues related to SkyWalking-infra-e2e labels Sep 30, 2021
@wu-sheng
Copy link
Member

If this has .exe suffix, then we need to be careful about dealing with skywalking-eyes checking or others in ASF doing check for our release. This could be identified as binary file, which is not allowed in the ASF source release. Meanwhile, according to your description, this should have a very clear document about what this exe is.

@wu-sheng
Copy link
Member

And for more importantly, does this enough for Windows? We have swtcl(having Windows binary, but set up Linux's binary only) and many other scripts, are they working too?

The reason I asked about is that, once we say something in the doc, these a/b/c are for Windows, we actually are saying, we are going to support infra-e2e in Windows, and users even expect the consistent setting for Windows and MacOS/Linux.

@kezhenxu94
Copy link
Member Author

If this has .exe suffix, then we need to be careful about dealing with skywalking-eyes checking or others in ASF doing check for our release. This could be identified as binary file, which is not allowed in the ASF source release. Meanwhile, according to your description, this should have a very clear document about what this exe is.

.exe is definitely binary file, and it is only distributed in binary tar, not source tar.

This issue is just to add a suffix .exe to the binary files, which were already distributed but not work because of lack of .exe.

And for more importantly, does this enough for Windows? We have swtcl(having Windows binary, but set up Linux's binary only) and many other scripts, are they working too?

The reason I asked about is that, once we say something in the doc, these a/b/c are for Windows, we actually are saying, we are going to support infra-e2e in Windows, and users even expect the consistent setting for Windows and MacOS/Linux.

For license-eye it should be supported in Windows, but for infra-e2e it depends on how the users compose the control file, I'll just remove the label infra-e2e.

@kezhenxu94 kezhenxu94 removed the infra-e2e Issues related to SkyWalking-infra-e2e label Sep 30, 2021
@wu-sheng
Copy link
Member

This issue is just to add a suffix .exe to the binary files, which were already distributed but not work because of lack of .exe.

Once it could be generated/compiled and located in binary tar only, it is good.

@wu-sheng wu-sheng changed the title Add “.exe” suffix to the Windows compiled executable program for skywalking-eyes and skywalking-infra-e2e Add “.exe” suffix to the Windows compiled executable program for skywalking-eyes Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug! license eye
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants