-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add “.exe” suffix to the Windows compiled executable program for skywalking-eyes #7845
Add “.exe” suffix to the Windows compiled executable program for skywalking-eyes #7845
Comments
If this has |
And for more importantly, does this enough for Windows? We have The reason I asked about is that, once we say something in the doc, these |
This issue is just to add a suffix
For |
Once it could be generated/compiled and located in binary tar only, it is good. |
Discussed in #7844
Originally posted by codeglzhang September 30, 2021


In skywalking-infra-e2e, we can use
make build
to get a Windows executable programskywalking-eyes\bin\windows\license-eye
. However, in the command line of Windows, whether the file is an executable program is determined by whether the file has a specific suffix, such as ".exe". Thus, commands such asbin/darwin/license-eye -c test/testdata/.licenserc_for_test_fix.yaml header check
will not be executed correctly under Windows.After renaming the file
skywalking-eyes\bin\windows\license-eye
toskywalking-eyes\bin\windows\license-eye.exe
, the command is executed.The same is true for
skywalking-infra-e2e
.The text was updated successfully, but these errors were encountered: