From 699b7352a36d8d11e1908d4319341e1ef7ddba6e Mon Sep 17 00:00:00 2001 From: Pierre Salagnac Date: Wed, 26 Feb 2025 14:57:40 +0100 Subject: [PATCH] Rely on adoc() like other tests --- .../TestPartialUpdateDeduplication.java | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/solr/core/src/test/org/apache/solr/update/processor/TestPartialUpdateDeduplication.java b/solr/core/src/test/org/apache/solr/update/processor/TestPartialUpdateDeduplication.java index aff729000ed..86fbc205a78 100644 --- a/solr/core/src/test/org/apache/solr/update/processor/TestPartialUpdateDeduplication.java +++ b/solr/core/src/test/org/apache/solr/update/processor/TestPartialUpdateDeduplication.java @@ -16,12 +16,8 @@ */ package org.apache.solr.update.processor; -import java.io.IOException; -import java.io.StringWriter; import java.util.Map; import org.apache.solr.SolrTestCaseJ4; -import org.apache.solr.client.solrj.impl.XMLRequestWriter; -import org.apache.solr.client.solrj.request.UpdateRequest; import org.apache.solr.common.SolrInputDocument; import org.junit.BeforeClass; import org.junit.Test; @@ -41,11 +37,9 @@ public void testPartialUpdates() throws Exception { doc.addField("id", "2a"); Map map = Map.of("set", "Hello Dude man!"); doc.addField("v_t", map); - UpdateRequest req = new UpdateRequest(); - req.add(doc); boolean exception_ok = false; try { - addDoc(getXML(req), chain); + addDoc(adoc(doc), chain); } catch (Exception e) { exception_ok = true; } @@ -59,18 +53,8 @@ public void testPartialUpdates() throws Exception { doc.addField("id", "2a"); map = Map.of("set", "name changed"); doc.addField("name", map); - req = new UpdateRequest(); - req.add(doc); - addDoc(getXML(req), chain); + addDoc(adoc(doc), chain); addDoc(commit(), chain); SignatureUpdateProcessorFactoryTest.checkNumDocs(1); } - - public String getXML(UpdateRequest request) throws IOException { - StringWriter writer = new StringWriter(); - XMLRequestWriter requestWriter = new XMLRequestWriter(); - requestWriter.writeXML(request, writer); - writer.close(); - return writer.toString(); - } }