fixed PR comments

apache · Jan 8, 2016 · 62c04ca · 62c04ca
1 parent fc45425
commit 62c04ca
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala b/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
@@ -101,11 +101,12 @@ private[ui] class StagePage(parent: StagesTab) extends WebUIPage("stage") {
       val parameterTaskPrevPageSize = request.getParameter("task.prevPageSize")
 
       val taskPage = Option(parameterTaskPage).map(_.toInt).getOrElse(1)
-      val taskSortColumn = Option(parameterTaskSortColumn).map {
-        sortColumn =>
-          // If sortColumn contains "/", `getParameter("task.sort")` will return 
-          // "%252F" when yarn mode. we need additional decode.
-          // See also SPARK-4313, YARN-2844.
+      val taskSortColumn = Option(parameterTaskSortColumn).map { sortColumn =>
+          // SPARK-12708
+          // Due to YARN-2844, "/" in the url will be encoded to "%252F" when
+          // running in yarn mode. `request.getParameter("task.sort")` will return
+          // "%252F". Therefore we need to decode it until we get the real column name.
+          // SPARK-4313 is similar to this issue.
           var column = sortColumn
           var decodedColumn = URLDecoder.decode(column, "UTF-8")
           while (column != decodedColumn) {