Skip to content

Commit

Permalink
[SPARK-48089][SS][CONNECT][FOLLOWUP][3.5] Disable Server Listener fai…
Browse files Browse the repository at this point in the history
…led 3.5 <> 4.0 test

### What changes were proposed in this pull request?

Disable the listener test. This test would fail after #46921, which is now reverted. The reason was because with #46921, the server starts a server side python process which serializes the `StreamingQueryProgress` object with the new `StreamingQueryProgress` change. But in the client, the client tries to deserialize `StreamingQueryProgress` use the old `StreamingQueryProgress` without the change, which caused serde error.

However, as the change is going to spark 4.0, and is considered a generally good improvement and does more good than harm, we would like to disable this test to bring back #46921.

### Why are the changes needed?

Unblock bringing back #46921

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No need

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #47468 from WweiL/3.5-disable-server-listener-test-cross-version.

Authored-by: Wei Liu <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
  • Loading branch information
WweiL authored and HyukjinKwon committed Jul 25, 2024
1 parent ada5dc2 commit 66b7cb9
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# limitations under the License.
#
import time
import os
import unittest

import pyspark.cloudpickle
from pyspark.sql.tests.streaming.test_streaming_listener import StreamingListenerTestsMixin
Expand Down Expand Up @@ -44,6 +46,9 @@ def onQueryTerminated(self, event):


class StreamingListenerParityTests(StreamingListenerTestsMixin, ReusedConnectTestCase):
@unittest.skipIf(
"SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "Failed with different Client <> Server"
)
def test_listener_events(self):
test_listener = TestListenerSpark()

Expand Down

0 comments on commit 66b7cb9

Please sign in to comment.