Skip to content

Commit

Permalink
remove outdated runtime Information scala home
Browse files Browse the repository at this point in the history 
Author: witgo <[email protected]>

Closes #728 from witgo/scala_home and squashes the following commits:

cdfd8be [witgo] Merge branch 'master' of https://github.com/apache/spark into scala_home
fac094a [witgo] remove outdated runtime Information scala home
  • Loading branch information
@witgo @pwendell
witgo authored and pwendell committed May 11, 2014
1 parent 70bcdef commit 6bee01d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions core/src/main/scala/org/apache/spark/SparkEnv.scala
View file
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,7 @@ object SparkEnv extends Logging {
val jvmInformation = Seq(
("Java Version", "%s (%s)".format(Properties.javaVersion, Properties.javaVendor)),

This comment has been minimized.

Sign in to view

Copy link
@jaceklaskowski

jaceklaskowski May 12, 2014

Contributor

I think using string interpolation would be way easier to read (though it's not very hard now):

("Java Version", s"${Properties.javaVersion} (${Properties.javaVendor})"),

With import Properties._ it'd get additional readability.

This comment has been minimized.

Sign in to view

Copy link
@witgo

witgo May 12, 2014

Author Contributor

@jaceklaskowski
About you said that. It's a good idea to a new Pull Request.

This comment has been minimized.

Sign in to view

Copy link
@jaceklaskowski

jaceklaskowski May 12, 2014

Contributor

As you wish...#748
("Java Home", Properties.javaHome),
("Scala Version", Properties.versionString),
("Scala Home", Properties.scalaHome)
("Scala Version", Properties.versionString)
).sorted

// Spark properties
Expand Down

0 comments on commit 6bee01d

Please sign in to comment.